OpenEJB
  1. OpenEJB
  2. OPENEJB-590

mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.7.0
    • Fix Version/s: 4.7.0
    • Component/s: None
    • Labels:
      None
    • Environment:
      win xp sp2

      Description

      mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone. This is because of the following in assembly/openejb-standalone/src/main/assembly/bin.xml.
      <fileSet>
      <directory>target/classes/</directory>
      <outputDirectory>bin/</outputDirectory>

      The problem is that when the above is executed by Maven, it finds that there are no files in target/classes, so it skips copying anything from this folder to the bin folder. Since, it skips the copying, it never creates the bin folder.

      1. openejb-590-1.patch
        4 kB
        karan singh malhi
      2. OPENEJB-590.patch
        0.8 kB
        karan singh malhi

        Activity

        Hide
        karan singh malhi added a comment -

        Fixed this issue.
        The files to be copied to the bin folder were available in openejb-standalone/src/main/resources.
        Changed openejb-standalone/src/main/assembly/bin to point to the resources folder instead of $

        {basedir}

        /target/classes

        Show
        karan singh malhi added a comment - Fixed this issue. The files to be copied to the bin folder were available in openejb-standalone/src/main/resources. Changed openejb-standalone/src/main/assembly/bin to point to the resources folder instead of $ {basedir} /target/classes
        Hide
        Mohammad Nour added a comment -

        RTC

        Show
        Mohammad Nour added a comment - RTC
        Hide
        Mohammad Nour added a comment -

        Applied
        --------------------------------------------------------------------------------------------------
        Sending assembly/openejb-standalone/src/main/assembly/bin.xml
        Transmitting file data .
        Committed revision 544704.

        Show
        Mohammad Nour added a comment - Applied -------------------------------------------------------------------------------------------------- Sending assembly/openejb-standalone/src/main/assembly/bin.xml Transmitting file data . Committed revision 544704.
        Hide
        karan singh malhi added a comment -

        The earlier patch did not copy the openejb file to the bin directory. It also did not clean up the target/classes and target/archive-tmp directories which are just required temporarily by the assembly to do filtering and copy filtered resources. Added the antrun plugin to do the clean up in the package phase

        Show
        karan singh malhi added a comment - The earlier patch did not copy the openejb file to the bin directory. It also did not clean up the target/classes and target/archive-tmp directories which are just required temporarily by the assembly to do filtering and copy filtered resources. Added the antrun plugin to do the clean up in the package phase
        Hide
        David Blevins added a comment -

        All committed. Thanks Karan!

        $ svn ci assembly
        Sending assembly/openejb-standalone/pom.xml
        Sending assembly/openejb-standalone/src/main/assembly/bin.xml
        Sending assembly/openejb-standalone/src/main/resources/README.txt
        Sending assembly/openejb-standalone/try.sh
        Transmitting file data ....
        Committed revision 550976.

        Show
        David Blevins added a comment - All committed. Thanks Karan! $ svn ci assembly Sending assembly/openejb-standalone/pom.xml Sending assembly/openejb-standalone/src/main/assembly/bin.xml Sending assembly/openejb-standalone/src/main/resources/README.txt Sending assembly/openejb-standalone/try.sh Transmitting file data .... Committed revision 550976.

          People

          • Assignee:
            karan singh malhi
            Reporter:
            karan singh malhi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development