Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0
    • Component/s: ejb31
    • Labels:
      None
    1. OPENEJB-1144.patch
      5 kB
      Thiago Veronezi
    2. OPENEJB-1144.patch
      5 kB
      Thiago Veronezi
    3. OPENEJB-1144.patch
      29 kB
      Thiago Veronezi
    4. OPENEJB-1144.patch
      27 kB
      Thiago Veronezi

      Issue Links

        Activity

        David Blevins created issue -
        David Blevins made changes -
        Field Original Value New Value
        Component/s ejb31 [ 12313252 ]
        David Blevins made changes -
        Link This issue relates to OPENEJB-1099 [ OPENEJB-1099 ]
        Hide
        Thiago Veronezi added a comment -

        I needed to create 2 extra classes. I didnt get the system working with a common class for both annotations (Stateful and Access timeout) because of the XmlType annotation of the xml dataholder field. For statefultimeaout we have "stateful-timeoutType", and for accesstimeout we have "access-timeoutType"...

        +@XmlType(name = "stateful-timeoutType", propOrder =

        { "timeout", "unit" })
        +@XmlType(name = "access-timeoutType", propOrder = { "timeout", "unit" }

        )

        The unittest was accusing "two fields with the same name".

        ************************************************

        For this first patch, the system is going to support only one value for accesstimeout, instead of the list, as discussed by email. If thats ok, we need to open a new issue to complete this feature to support a list.

        Show
        Thiago Veronezi added a comment - I needed to create 2 extra classes. I didnt get the system working with a common class for both annotations (Stateful and Access timeout) because of the XmlType annotation of the xml dataholder field. For statefultimeaout we have "stateful-timeoutType", and for accesstimeout we have "access-timeoutType"... +@XmlType(name = "stateful-timeoutType", propOrder = { "timeout", "unit" }) +@XmlType(name = "access-timeoutType", propOrder = { "timeout", "unit" } ) The unittest was accusing "two fields with the same name". ************************************************ For this first patch, the system is going to support only one value for accesstimeout, instead of the list, as discussed by email. If thats ok, we need to open a new issue to complete this feature to support a list.
        Thiago Veronezi made changes -
        Attachment OPENEJB-1144.patch [ 12445980 ]
        Hide
        Thiago Veronezi added a comment -

        I had forgot to add the apache header to the new files;
        I also added some changes to the AnnotationDeployer class. Now the system is merging the configuration information from the xml file and the class annotations;

        Show
        Thiago Veronezi added a comment - I had forgot to add the apache header to the new files; I also added some changes to the AnnotationDeployer class. Now the system is merging the configuration information from the xml file and the class annotations;
        Thiago Veronezi made changes -
        Attachment OPENEJB-1144.patch [ 12446147 ]
        David Blevins committed 951778 (1 file)
        Reviews: none

        Patch from Thiago Veronezi, OPENEJB-1144 and OPENEJB-1146
        Partial support for @StatefulTimeout and @AccessTimeout related xml and deployment support
        Thanks, Thiago!

        David Blevins committed 953150 (2 files)
        Reviews: none

        Patch from Thiago Veronezi
        OPENEJB-1099: Reentrant calls to @Stateful beans unsupported
        OPENEJB-1144: @Stateful javax.ejb.AccessTimeout
        OPENEJB-1145: @Stateful javax.ejb.ConcurrentAccessTimeoutException

        David Blevins made changes -
        Assignee Thiago Veronezi [ tveronezi ]
        Fix Version/s 3.2-beta-1 [ 12315050 ]
        Hide
        Thiago Veronezi added a comment -

        Simplifying the test case.

        Show
        Thiago Veronezi added a comment - Simplifying the test case.
        Thiago Veronezi made changes -
        Attachment OPENEJB-1144.patch [ 12451400 ]
        Hide
        Thiago Veronezi added a comment -

        as asked: attach new patches using an absolute path

        Show
        Thiago Veronezi added a comment - as asked: attach new patches using an absolute path
        Thiago Veronezi made changes -
        Attachment OPENEJB-1144.patch [ 12452526 ]
        Jarek Gawor made changes -
        Assignee Thiago Veronezi [ tveronezi ] Jarek Gawor [ gawor@mcs.anl.gov ]
        gawor committed 989259 (12 files)
        Reviews: none

        OPENEJB-1144: Discover and process @AccessTimeout annotations on methods. Support per-method @AccessTimeout and improve locking in stateful container.

        Hide
        Jarek Gawor added a comment -

        In revision 989259 I added support to the stateful container for per-method @AccessTimeout annotations. I also improved some locking in the stateful container and committed Thiago's test patch.

        Show
        Jarek Gawor added a comment - In revision 989259 I added support to the stateful container for per-method @AccessTimeout annotations. I also improved some locking in the stateful container and committed Thiago's test patch.
        Jarek Gawor made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 3.2 [ 12315051 ]
        Fix Version/s 3.2-beta-1 [ 12315050 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Jarek Gawor
            Reporter:
            David Blevins
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development