Oozie
  1. Oozie
  2. OOZIE-819

Interrupt map doesn't have unique set of commands for a given jobid

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 3.2.0, trunk
    • Component/s: None
    • Labels:
      None

      Description

      This jira proposes to fix the following issues

      1) Interrupt map should have unique values of interrupt commands for a given job id
      2) Fix the usage of 'used' implementation in Xcommand
      3) Remove white spaces for interrupt property in oozie-default. This is similar to issue identified in oozie-797.

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4851/
        -----------------------------------------------------------

        Review request for oozie.

        Summary
        -------

        https://issues.apache.org/jira/browse/OOZIE-819

        This addresses bug oozie-819.
        https://issues.apache.org/jira/browse/oozie-819

        Diffs


        trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1327678
        trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java 1327678
        trunk/core/src/main/resources/oozie-default.xml 1327678

        Diff: https://reviews.apache.org/r/4851/diff

        Testing
        -------

        Tested after runnning examples

        Thanks,

        Virag

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4851/ ----------------------------------------------------------- Review request for oozie. Summary ------- https://issues.apache.org/jira/browse/OOZIE-819 This addresses bug oozie-819. https://issues.apache.org/jira/browse/oozie-819 Diffs trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1327678 trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java 1327678 trunk/core/src/main/resources/oozie-default.xml 1327678 Diff: https://reviews.apache.org/r/4851/diff Testing ------- Tested after runnning examples Thanks, Virag
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4851/#review7195
        -----------------------------------------------------------

        Ensuring unique job-id for specific command type is essential. Good catch!

        • Mona

        On 2012-04-24 01:55:07, Virag Kothari wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4851/

        -----------------------------------------------------------

        (Updated 2012-04-24 01:55:07)

        Review request for oozie.

        Summary

        -------

        https://issues.apache.org/jira/browse/OOZIE-819

        This addresses bug oozie-819.

        https://issues.apache.org/jira/browse/oozie-819

        Diffs

        -----

        trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1327678

        trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java 1327678

        trunk/core/src/main/resources/oozie-default.xml 1327678

        Diff: https://reviews.apache.org/r/4851/diff

        Testing

        -------

        Tested after runnning examples

        Thanks,

        Virag

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4851/#review7195 ----------------------------------------------------------- Ensuring unique job-id for specific command type is essential. Good catch! Mona On 2012-04-24 01:55:07, Virag Kothari wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4851/ ----------------------------------------------------------- (Updated 2012-04-24 01:55:07) Review request for oozie. Summary ------- https://issues.apache.org/jira/browse/OOZIE-819 This addresses bug oozie-819. https://issues.apache.org/jira/browse/oozie-819 Diffs ----- trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1327678 trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java 1327678 trunk/core/src/main/resources/oozie-default.xml 1327678 Diff: https://reviews.apache.org/r/4851/diff Testing ------- Tested after runnning examples Thanks, Virag
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4851/
        -----------------------------------------------------------

        (Updated 2012-04-27 16:30:36.963695)

        Review request for oozie.

        Changes
        -------

        setting used variable only if the interrupt cmd is sure to get executed

        Summary
        -------

        https://issues.apache.org/jira/browse/OOZIE-819

        This addresses bug oozie-819.
        https://issues.apache.org/jira/browse/oozie-819

        Diffs (updated)


        trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1327678
        trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java 1327678
        trunk/core/src/main/resources/oozie-default.xml 1327678

        Diff: https://reviews.apache.org/r/4851/diff

        Testing
        -------

        Tested after runnning examples

        Thanks,

        Virag

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4851/ ----------------------------------------------------------- (Updated 2012-04-27 16:30:36.963695) Review request for oozie. Changes ------- setting used variable only if the interrupt cmd is sure to get executed Summary ------- https://issues.apache.org/jira/browse/OOZIE-819 This addresses bug oozie-819. https://issues.apache.org/jira/browse/oozie-819 Diffs (updated) trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1327678 trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java 1327678 trunk/core/src/main/resources/oozie-default.xml 1327678 Diff: https://reviews.apache.org/r/4851/diff Testing ------- Tested after runnning examples Thanks, Virag
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4851/
        -----------------------------------------------------------

        (Updated 2012-04-27 22:38:33.833947)

        Review request for oozie.

        Changes
        -------

        Changing from hashset to linkedhashset to preserve insertion order for interruptcmds

        Summary
        -------

        https://issues.apache.org/jira/browse/OOZIE-819

        This addresses bug oozie-819.
        https://issues.apache.org/jira/browse/oozie-819

        Diffs (updated)


        trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1327678
        trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java 1327678
        trunk/core/src/main/resources/oozie-default.xml 1327678

        Diff: https://reviews.apache.org/r/4851/diff

        Testing
        -------

        Tested after runnning examples

        Thanks,

        Virag

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4851/ ----------------------------------------------------------- (Updated 2012-04-27 22:38:33.833947) Review request for oozie. Changes ------- Changing from hashset to linkedhashset to preserve insertion order for interruptcmds Summary ------- https://issues.apache.org/jira/browse/OOZIE-819 This addresses bug oozie-819. https://issues.apache.org/jira/browse/oozie-819 Diffs (updated) trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1327678 trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java 1327678 trunk/core/src/main/resources/oozie-default.xml 1327678 Diff: https://reviews.apache.org/r/4851/diff Testing ------- Tested after runnning examples Thanks, Virag
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4851/#review7393
        -----------------------------------------------------------

        Ship it!

        +1 committing

        • Mohammad

        On 2012-04-27 22:38:33, Virag Kothari wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4851/

        -----------------------------------------------------------

        (Updated 2012-04-27 22:38:33)

        Review request for oozie.

        Summary

        -------

        https://issues.apache.org/jira/browse/OOZIE-819

        This addresses bug oozie-819.

        https://issues.apache.org/jira/browse/oozie-819

        Diffs

        -----

        trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1327678

        trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java 1327678

        trunk/core/src/main/resources/oozie-default.xml 1327678

        Diff: https://reviews.apache.org/r/4851/diff

        Testing

        -------

        Tested after runnning examples

        Thanks,

        Virag

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4851/#review7393 ----------------------------------------------------------- Ship it! +1 committing Mohammad On 2012-04-27 22:38:33, Virag Kothari wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4851/ ----------------------------------------------------------- (Updated 2012-04-27 22:38:33) Review request for oozie. Summary ------- https://issues.apache.org/jira/browse/OOZIE-819 This addresses bug oozie-819. https://issues.apache.org/jira/browse/oozie-819 Diffs ----- trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1327678 trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java 1327678 trunk/core/src/main/resources/oozie-default.xml 1327678 Diff: https://reviews.apache.org/r/4851/diff Testing ------- Tested after runnning examples Thanks, Virag
        Hide
        Virag Kothari added a comment -

        For the patch committed in trunk with this JIRA ID (also available under the same JIRA ID in Apache ReviewBoard system), I grant license to ASF for inclusion in ASF works (as per the Apache License §5)

        Show
        Virag Kothari added a comment - For the patch committed in trunk with this JIRA ID (also available under the same JIRA ID in Apache ReviewBoard system), I grant license to ASF for inclusion in ASF works (as per the Apache License §5)

          People

          • Assignee:
            Virag Kothari
            Reporter:
            Virag Kothari
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development