Oozie
  1. Oozie
  2. OOZIE-813

Sub-workflow child job does not get group name even if parent carries it

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.0
    • Fix Version/s: 3.2.0
    • Component/s: None
    • Labels:

      Description

      Subworkflow AE needs to account for assigning group/acl name to child wf if parent has it. <propagate-configuration> should not be needed for something as basic as group/acl name.

      Example output:

      sub workflow child workflow job does not have the group name.

      $ oozie jobs -len 2
      Job ID App Name Status User Group Started Ended
      -----------------------------------------------------------------------------------------------------------
      0002-oozie-oozi-W child-wf KILLED joe - 2012-03-30 21:28 2012-03-30 21:31
      -----------------------------------------------------------------------------------------------------------
      0001-oozie-oozi-W parent-wf KILLED joe users 2012-03-30 21:28 2012-03-30 21:31

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4715/
        -----------------------------------------------------------

        Review request for oozie.

        Summary
        -------

        Subworkflow AE needs to account for assigning group/acl name to child wf if parent has it. <propagate-configuration> should not be needed for something as basic as group/acl name.

        Example output:

        sub workflow child workflow job does not have the group name.

        $ oozie jobs -len 2
        Job ID App Name Status User Group Started Ended
        -----------------------------------------------------------------------------------------------------------
        0002-oozie-oozi-W child-wf KILLED joe - 2012-03-30 21:28 2012-03-30 21:31
        -----------------------------------------------------------------------------------------------------------
        0001-oozie-oozi-W parent-wf KILLED joe users 2012-03-30 21:28 2012-03-30 21:31

        This addresses bug OOZIE-813.
        https://issues.apache.org/jira/browse/OOZIE-813

        Diffs


        trunk/core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 1325599
        trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 1325599

        Diff: https://reviews.apache.org/r/4715/diff

        Testing
        -------

        yes. unit test for both negative and positive cases

        Thanks,

        Mona

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4715/ ----------------------------------------------------------- Review request for oozie. Summary ------- Subworkflow AE needs to account for assigning group/acl name to child wf if parent has it. <propagate-configuration> should not be needed for something as basic as group/acl name. Example output: sub workflow child workflow job does not have the group name. $ oozie jobs -len 2 Job ID App Name Status User Group Started Ended ----------------------------------------------------------------------------------------------------------- 0002-oozie-oozi-W child-wf KILLED joe - 2012-03-30 21:28 2012-03-30 21:31 ----------------------------------------------------------------------------------------------------------- 0001-oozie-oozi-W parent-wf KILLED joe users 2012-03-30 21:28 2012-03-30 21:31 This addresses bug OOZIE-813 . https://issues.apache.org/jira/browse/OOZIE-813 Diffs trunk/core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 1325599 trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 1325599 Diff: https://reviews.apache.org/r/4715/diff Testing ------- yes. unit test for both negative and positive cases Thanks, Mona
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4715/#review6962
        -----------------------------------------------------------

        Ship it!

        +1 committing

        • Mohammad

        On 2012-04-14 03:17:18, Mona Chitnis wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4715/

        -----------------------------------------------------------

        (Updated 2012-04-14 03:17:18)

        Review request for oozie.

        Summary

        -------

        Subworkflow AE needs to account for assigning group/acl name to child wf if parent has it. <propagate-configuration> should not be needed for something as basic as group/acl name.

        Example output:

        sub workflow child workflow job does not have the group name.

        $ oozie jobs -len 2

        Job ID App Name Status User Group Started Ended

        -----------------------------------------------------------------------------------------------------------

        0002-oozie-oozi-W child-wf KILLED joe - 2012-03-30 21:28 2012-03-30 21:31

        -----------------------------------------------------------------------------------------------------------

        0001-oozie-oozi-W parent-wf KILLED joe users 2012-03-30 21:28 2012-03-30 21:31

        This addresses bug OOZIE-813.

        https://issues.apache.org/jira/browse/OOZIE-813

        Diffs

        -----

        trunk/core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 1325599

        trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 1325599

        Diff: https://reviews.apache.org/r/4715/diff

        Testing

        -------

        yes. unit test for both negative and positive cases

        Thanks,

        Mona

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4715/#review6962 ----------------------------------------------------------- Ship it! +1 committing Mohammad On 2012-04-14 03:17:18, Mona Chitnis wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4715/ ----------------------------------------------------------- (Updated 2012-04-14 03:17:18) Review request for oozie. Summary ------- Subworkflow AE needs to account for assigning group/acl name to child wf if parent has it. <propagate-configuration> should not be needed for something as basic as group/acl name. Example output: sub workflow child workflow job does not have the group name. $ oozie jobs -len 2 Job ID App Name Status User Group Started Ended ----------------------------------------------------------------------------------------------------------- 0002-oozie-oozi-W child-wf KILLED joe - 2012-03-30 21:28 2012-03-30 21:31 ----------------------------------------------------------------------------------------------------------- 0001-oozie-oozi-W parent-wf KILLED joe users 2012-03-30 21:28 2012-03-30 21:31 This addresses bug OOZIE-813 . https://issues.apache.org/jira/browse/OOZIE-813 Diffs ----- trunk/core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 1325599 trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 1325599 Diff: https://reviews.apache.org/r/4715/diff Testing ------- yes. unit test for both negative and positive cases Thanks, Mona
        Hide
        Mona Chitnis added a comment -

        For the patch committed in trunk with this JIRA ID (also available under the same JIRA ID in Apache ReviewBoard system), I grant license to ASF for inclusion in ASF works (as per the Apache License §5) 

        Show
        Mona Chitnis added a comment - For the patch committed in trunk with this JIRA ID (also available under the same JIRA ID in Apache ReviewBoard system), I grant license to ASF for inclusion in ASF works (as per the Apache License §5) 

          People

          • Assignee:
            Mona Chitnis
            Reporter:
            Mona Chitnis
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development