Oozie
  1. Oozie
  2. OOZIE-763

Add findbugs and clover plugin for CI

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.0
    • Fix Version/s: 3.2.0
    • Component/s: build
    • Labels:
      None

      Activity

      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4353/
      -----------------------------------------------------------

      Review request for oozie.

      Summary
      -------

      https://issues.apache.org/jira/browse/OOZIE-763

      This addresses bug oozie-763.
      https://issues.apache.org/jira/browse/oozie-763

      Diffs


      trunk/pom.xml 1300619

      Diff: https://reviews.apache.org/r/4353/diff

      Testing
      -------

      Tested mvn clover2:instrument clover2: aggregate clover2:clover and mvn findbugs:findbugs...reports are generated

      Thanks,

      Virag

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4353/ ----------------------------------------------------------- Review request for oozie. Summary ------- https://issues.apache.org/jira/browse/OOZIE-763 This addresses bug oozie-763. https://issues.apache.org/jira/browse/oozie-763 Diffs trunk/pom.xml 1300619 Diff: https://reviews.apache.org/r/4353/diff Testing ------- Tested mvn clover2:instrument clover2: aggregate clover2:clover and mvn findbugs:findbugs...reports are generated Thanks, Virag
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4353/#review5968
      -----------------------------------------------------------

      trunk/pom.xml
      <https://reviews.apache.org/r/4353/#comment12942>

      patch should not have TABS

      • Alejandro

      On 2012-03-14 17:00:47, Virag Kothari wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/4353/

      -----------------------------------------------------------

      (Updated 2012-03-14 17:00:47)

      Review request for oozie.

      Summary

      -------

      https://issues.apache.org/jira/browse/OOZIE-763

      This addresses bug oozie-763.

      https://issues.apache.org/jira/browse/oozie-763

      Diffs

      -----

      trunk/pom.xml 1300619

      Diff: https://reviews.apache.org/r/4353/diff

      Testing

      -------

      Tested mvn clover2:instrument clover2: aggregate clover2:clover and mvn findbugs:findbugs...reports are generated

      Thanks,

      Virag

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4353/#review5968 ----------------------------------------------------------- trunk/pom.xml < https://reviews.apache.org/r/4353/#comment12942 > patch should not have TABS Alejandro On 2012-03-14 17:00:47, Virag Kothari wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4353/ ----------------------------------------------------------- (Updated 2012-03-14 17:00:47) Review request for oozie. Summary ------- https://issues.apache.org/jira/browse/OOZIE-763 This addresses bug oozie-763. https://issues.apache.org/jira/browse/oozie-763 Diffs ----- trunk/pom.xml 1300619 Diff: https://reviews.apache.org/r/4353/diff Testing ------- Tested mvn clover2:instrument clover2: aggregate clover2:clover and mvn findbugs:findbugs...reports are generated Thanks, Virag
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4353/
      -----------------------------------------------------------

      (Updated 2012-03-14 23:29:00.983563)

      Review request for oozie.

      Changes
      -------

      Removing tabs

      Summary
      -------

      https://issues.apache.org/jira/browse/OOZIE-763

      This addresses bug oozie-763.
      https://issues.apache.org/jira/browse/oozie-763

      Diffs (updated)


      trunk/pom.xml 1300776

      Diff: https://reviews.apache.org/r/4353/diff

      Testing
      -------

      Tested mvn clover2:instrument clover2: aggregate clover2:clover and mvn findbugs:findbugs...reports are generated

      Thanks,

      Virag

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4353/ ----------------------------------------------------------- (Updated 2012-03-14 23:29:00.983563) Review request for oozie. Changes ------- Removing tabs Summary ------- https://issues.apache.org/jira/browse/OOZIE-763 This addresses bug oozie-763. https://issues.apache.org/jira/browse/oozie-763 Diffs (updated) trunk/pom.xml 1300776 Diff: https://reviews.apache.org/r/4353/diff Testing ------- Tested mvn clover2:instrument clover2: aggregate clover2:clover and mvn findbugs:findbugs...reports are generated Thanks, Virag
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4353/#review5975
      -----------------------------------------------------------

      patch still has TABs

      in order for clover to work in Apache CI, clover.license should be defined as property with the following default value of /home/jenkins/tools/clover/latest/lib/clover.license

      • Alejandro

      On 2012-03-14 23:29:00, Virag Kothari wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/4353/

      -----------------------------------------------------------

      (Updated 2012-03-14 23:29:00)

      Review request for oozie.

      Summary

      -------

      https://issues.apache.org/jira/browse/OOZIE-763

      This addresses bug oozie-763.

      https://issues.apache.org/jira/browse/oozie-763

      Diffs

      -----

      trunk/pom.xml 1300776

      Diff: https://reviews.apache.org/r/4353/diff

      Testing

      -------

      Tested mvn clover2:instrument clover2: aggregate clover2:clover and mvn findbugs:findbugs...reports are generated

      Thanks,

      Virag

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4353/#review5975 ----------------------------------------------------------- patch still has TABs in order for clover to work in Apache CI, clover.license should be defined as property with the following default value of /home/jenkins/tools/clover/latest/lib/clover.license Alejandro On 2012-03-14 23:29:00, Virag Kothari wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4353/ ----------------------------------------------------------- (Updated 2012-03-14 23:29:00) Review request for oozie. Summary ------- https://issues.apache.org/jira/browse/OOZIE-763 This addresses bug oozie-763. https://issues.apache.org/jira/browse/oozie-763 Diffs ----- trunk/pom.xml 1300776 Diff: https://reviews.apache.org/r/4353/diff Testing ------- Tested mvn clover2:instrument clover2: aggregate clover2:clover and mvn findbugs:findbugs...reports are generated Thanks, Virag
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4353/
      -----------------------------------------------------------

      (Updated 2012-03-15 00:43:45.981592)

      Review request for oozie.

      Changes
      -------

      clover license added.. thanks Alejandro
      all tabs gone from the patch

      Summary
      -------

      https://issues.apache.org/jira/browse/OOZIE-763

      This addresses bug oozie-763.
      https://issues.apache.org/jira/browse/oozie-763

      Diffs (updated)


      trunk/pom.xml 1300776

      Diff: https://reviews.apache.org/r/4353/diff

      Testing
      -------

      Tested mvn clover2:instrument clover2: aggregate clover2:clover and mvn findbugs:findbugs...reports are generated

      Thanks,

      Virag

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4353/ ----------------------------------------------------------- (Updated 2012-03-15 00:43:45.981592) Review request for oozie. Changes ------- clover license added.. thanks Alejandro all tabs gone from the patch Summary ------- https://issues.apache.org/jira/browse/OOZIE-763 This addresses bug oozie-763. https://issues.apache.org/jira/browse/oozie-763 Diffs (updated) trunk/pom.xml 1300776 Diff: https://reviews.apache.org/r/4353/diff Testing ------- Tested mvn clover2:instrument clover2: aggregate clover2:clover and mvn findbugs:findbugs...reports are generated Thanks, Virag
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4353/#review5981
      -----------------------------------------------------------

      Ship it!

      • Alejandro

      On 2012-03-15 00:43:45, Virag Kothari wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/4353/

      -----------------------------------------------------------

      (Updated 2012-03-15 00:43:45)

      Review request for oozie.

      Summary

      -------

      https://issues.apache.org/jira/browse/OOZIE-763

      This addresses bug oozie-763.

      https://issues.apache.org/jira/browse/oozie-763

      Diffs

      -----

      trunk/pom.xml 1300776

      Diff: https://reviews.apache.org/r/4353/diff

      Testing

      -------

      Tested mvn clover2:instrument clover2: aggregate clover2:clover and mvn findbugs:findbugs...reports are generated

      Thanks,

      Virag

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4353/#review5981 ----------------------------------------------------------- Ship it! Alejandro On 2012-03-15 00:43:45, Virag Kothari wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4353/ ----------------------------------------------------------- (Updated 2012-03-15 00:43:45) Review request for oozie. Summary ------- https://issues.apache.org/jira/browse/OOZIE-763 This addresses bug oozie-763. https://issues.apache.org/jira/browse/oozie-763 Diffs ----- trunk/pom.xml 1300776 Diff: https://reviews.apache.org/r/4353/diff Testing ------- Tested mvn clover2:instrument clover2: aggregate clover2:clover and mvn findbugs:findbugs...reports are generated Thanks, Virag
      Hide
      Alejandro Abdelnur added a comment -

      Thanks Virag. Committed to trunk

      Show
      Alejandro Abdelnur added a comment - Thanks Virag. Committed to trunk
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4353/
      -----------------------------------------------------------

      (Updated 2012-03-15 03:43:33.907146)

      Review request for oozie.

      Summary (updated)
      -------

      https://issues.apache.org/jira/browse/OOZIE-763

      This addresses bug oozie-763.
      https://issues.apache.org/jira/browse/oozie-763

      Diffs


      trunk/pom.xml 1300776

      Diff: https://reviews.apache.org/r/4353/diff

      Testing
      -------

      Tested mvn clover2:instrument clover2: aggregate clover2:clover and mvn findbugs:findbugs...reports are generated

      Thanks,

      Virag

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4353/ ----------------------------------------------------------- (Updated 2012-03-15 03:43:33.907146) Review request for oozie. Summary (updated) ------- https://issues.apache.org/jira/browse/OOZIE-763 This addresses bug oozie-763. https://issues.apache.org/jira/browse/oozie-763 Diffs trunk/pom.xml 1300776 Diff: https://reviews.apache.org/r/4353/diff Testing ------- Tested mvn clover2:instrument clover2: aggregate clover2:clover and mvn findbugs:findbugs...reports are generated Thanks, Virag
      Hide
      Virag Kothari added a comment -

      For the patch committed in trunk with this JIRA ID (also available under the same JIRA ID in Apache ReviewBoard system), I grant license to ASF for inclusion in ASF works (as per the Apache License §5)

      Show
      Virag Kothari added a comment - For the patch committed in trunk with this JIRA ID (also available under the same JIRA ID in Apache ReviewBoard system), I grant license to ASF for inclusion in ASF works (as per the Apache License §5)

        People

        • Assignee:
          Virag Kothari
          Reporter:
          Virag Kothari
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development