Oozie
  1. Oozie
  2. OOZIE-758

Oozie logs should record job-id for when job is submitted

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.0
    • Fix Version/s: 3.2.0
    • Component/s: None
    • Labels:

      Description

      The job Id should be recorded to oozie.log if the job was submited with option -submit and not just with -run. This helps filtering through the logs for submitted jobs.

      Since this is a change to only turn on a particular logging part, no unit tests applicable.

        Activity

        Hide
        Mona Chitnis added a comment -

        For the patch committed in trunk with this JIRA ID (also available under the same JIRA ID in Apache ReviewBoard system), I grant license to ASF for inclusion in ASF works (as per the Apache License §5) 

        Show
        Mona Chitnis added a comment - For the patch committed in trunk with this JIRA ID (also available under the same JIRA ID in Apache ReviewBoard system), I grant license to ASF for inclusion in ASF works (as per the Apache License §5) 
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4378/#review6164
        -----------------------------------------------------------

        Ship it!

        +1 committing

        • Mohammad

        On 2012-03-21 02:06:28, Mona Chitnis wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4378/

        -----------------------------------------------------------

        (Updated 2012-03-21 02:06:28)

        Review request for oozie.

        Summary

        -------

        The job Id was not being recorded to oozie.log if the job was submited with option -submit instead of -run. This helps filtering through the logs for submitted jobs.

        Since this is a logging addition, no unit tests applicable.

        This addresses bug OOZIE-758.

        https://issues.apache.org/jira/browse/OOZIE-758

        Diffs

        -----

        trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1301249

        Diff: https://reviews.apache.org/r/4378/diff

        Testing

        -------

        Thanks,

        Mona

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4378/#review6164 ----------------------------------------------------------- Ship it! +1 committing Mohammad On 2012-03-21 02:06:28, Mona Chitnis wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4378/ ----------------------------------------------------------- (Updated 2012-03-21 02:06:28) Review request for oozie. Summary ------- The job Id was not being recorded to oozie.log if the job was submited with option -submit instead of -run. This helps filtering through the logs for submitted jobs. Since this is a logging addition, no unit tests applicable. This addresses bug OOZIE-758 . https://issues.apache.org/jira/browse/OOZIE-758 Diffs ----- trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1301249 Diff: https://reviews.apache.org/r/4378/diff Testing ------- Thanks, Mona
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4378/
        -----------------------------------------------------------

        (Updated 2012-03-21 02:06:28.658700)

        Review request for oozie.

        Changes
        -------

        Fixed to get Job-id recorded as part of Log prefix in SubmitXCommand.

        Summary
        -------

        The job Id was not being recorded to oozie.log if the job was submited with option -submit instead of -run. This helps filtering through the logs for submitted jobs.

        Since this is a logging addition, no unit tests applicable.

        This addresses bug OOZIE-758.
        https://issues.apache.org/jira/browse/OOZIE-758

        Diffs (updated)


        trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1301249

        Diff: https://reviews.apache.org/r/4378/diff

        Testing
        -------

        Thanks,

        Mona

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4378/ ----------------------------------------------------------- (Updated 2012-03-21 02:06:28.658700) Review request for oozie. Changes ------- Fixed to get Job-id recorded as part of Log prefix in SubmitXCommand. Summary ------- The job Id was not being recorded to oozie.log if the job was submited with option -submit instead of -run. This helps filtering through the logs for submitted jobs. Since this is a logging addition, no unit tests applicable. This addresses bug OOZIE-758 . https://issues.apache.org/jira/browse/OOZIE-758 Diffs (updated) trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1301249 Diff: https://reviews.apache.org/r/4378/diff Testing ------- Thanks, Mona
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-03-19 21:41:28, Mohammad Islam wrote:

        > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java, line 170

        > <https://reviews.apache.org/r/4378/diff/1/?file=92894#file92894line170>

        >

        > Mona,

        > Alejandro was asking, we don't need to explicitly print the WF ID, it will be automatically added.. Status should be ok.

        Mona Chitnis wrote:

        In my tests, the ID does not get automatically added for SubmitXCommand in the logging prefix e.g. USER[?] GROUP[users] TOKEN[-] APP[-] JOB[-] ACTION[-]. Hence the explicit output.

        in that case, the log setting is not working correctly. please find the reason.

        • Mohammad

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4378/#review6085
        -----------------------------------------------------------

        On 2012-03-16 04:19:15, Mona Chitnis wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4378/

        -----------------------------------------------------------

        (Updated 2012-03-16 04:19:15)

        Review request for oozie.

        Summary

        -------

        The job Id was not being recorded to oozie.log if the job was submited with option -submit instead of -run. This helps filtering through the logs for submitted jobs.

        Since this is a logging addition, no unit tests applicable.

        This addresses bug OOZIE-758.

        https://issues.apache.org/jira/browse/OOZIE-758

        Diffs

        -----

        trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1301249

        Diff: https://reviews.apache.org/r/4378/diff

        Testing

        -------

        Thanks,

        Mona

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-03-19 21:41:28, Mohammad Islam wrote: > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java, line 170 > < https://reviews.apache.org/r/4378/diff/1/?file=92894#file92894line170 > > > Mona, > Alejandro was asking, we don't need to explicitly print the WF ID, it will be automatically added.. Status should be ok. Mona Chitnis wrote: In my tests, the ID does not get automatically added for SubmitXCommand in the logging prefix e.g. USER [?] GROUP [users] TOKEN [-] APP [-] JOB [-] ACTION [-] . Hence the explicit output. in that case, the log setting is not working correctly. please find the reason. Mohammad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4378/#review6085 ----------------------------------------------------------- On 2012-03-16 04:19:15, Mona Chitnis wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4378/ ----------------------------------------------------------- (Updated 2012-03-16 04:19:15) Review request for oozie. Summary ------- The job Id was not being recorded to oozie.log if the job was submited with option -submit instead of -run. This helps filtering through the logs for submitted jobs. Since this is a logging addition, no unit tests applicable. This addresses bug OOZIE-758 . https://issues.apache.org/jira/browse/OOZIE-758 Diffs ----- trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1301249 Diff: https://reviews.apache.org/r/4378/diff Testing ------- Thanks, Mona
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-03-19 21:41:28, Mohammad Islam wrote:

        > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java, line 170

        > <https://reviews.apache.org/r/4378/diff/1/?file=92894#file92894line170>

        >

        > Mona,

        > Alejandro was asking, we don't need to explicitly print the WF ID, it will be automatically added.. Status should be ok.

        In my tests, the ID does not get automatically added for SubmitXCommand in the logging prefix e.g. USER[?] GROUP[users] TOKEN[-] APP[-] JOB[-] ACTION[-]. Hence the explicit output.

        • Mona

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4378/#review6085
        -----------------------------------------------------------

        On 2012-03-16 04:19:15, Mona Chitnis wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4378/

        -----------------------------------------------------------

        (Updated 2012-03-16 04:19:15)

        Review request for oozie.

        Summary

        -------

        The job Id was not being recorded to oozie.log if the job was submited with option -submit instead of -run. This helps filtering through the logs for submitted jobs.

        Since this is a logging addition, no unit tests applicable.

        This addresses bug OOZIE-758.

        https://issues.apache.org/jira/browse/OOZIE-758

        Diffs

        -----

        trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1301249

        Diff: https://reviews.apache.org/r/4378/diff

        Testing

        -------

        Thanks,

        Mona

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-03-19 21:41:28, Mohammad Islam wrote: > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java, line 170 > < https://reviews.apache.org/r/4378/diff/1/?file=92894#file92894line170 > > > Mona, > Alejandro was asking, we don't need to explicitly print the WF ID, it will be automatically added.. Status should be ok. In my tests, the ID does not get automatically added for SubmitXCommand in the logging prefix e.g. USER [?] GROUP [users] TOKEN [-] APP [-] JOB [-] ACTION [-] . Hence the explicit output. Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4378/#review6085 ----------------------------------------------------------- On 2012-03-16 04:19:15, Mona Chitnis wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4378/ ----------------------------------------------------------- (Updated 2012-03-16 04:19:15) Review request for oozie. Summary ------- The job Id was not being recorded to oozie.log if the job was submited with option -submit instead of -run. This helps filtering through the logs for submitted jobs. Since this is a logging addition, no unit tests applicable. This addresses bug OOZIE-758 . https://issues.apache.org/jira/browse/OOZIE-758 Diffs ----- trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1301249 Diff: https://reviews.apache.org/r/4378/diff Testing ------- Thanks, Mona
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4378/#review6085
        -----------------------------------------------------------

        trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java
        <https://reviews.apache.org/r/4378/#comment13061>

        Mona,
        Alejandro was asking, we don't need to explicitly print the WF ID, it will be automatically added.. Status should be ok.

        • Mohammad

        On 2012-03-16 04:19:15, Mona Chitnis wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4378/

        -----------------------------------------------------------

        (Updated 2012-03-16 04:19:15)

        Review request for oozie.

        Summary

        -------

        The job Id was not being recorded to oozie.log if the job was submited with option -submit instead of -run. This helps filtering through the logs for submitted jobs.

        Since this is a logging addition, no unit tests applicable.

        This addresses bug OOZIE-758.

        https://issues.apache.org/jira/browse/OOZIE-758

        Diffs

        -----

        trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1301249

        Diff: https://reviews.apache.org/r/4378/diff

        Testing

        -------

        Thanks,

        Mona

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4378/#review6085 ----------------------------------------------------------- trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java < https://reviews.apache.org/r/4378/#comment13061 > Mona, Alejandro was asking, we don't need to explicitly print the WF ID, it will be automatically added.. Status should be ok. Mohammad On 2012-03-16 04:19:15, Mona Chitnis wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4378/ ----------------------------------------------------------- (Updated 2012-03-16 04:19:15) Review request for oozie. Summary ------- The job Id was not being recorded to oozie.log if the job was submited with option -submit instead of -run. This helps filtering through the logs for submitted jobs. Since this is a logging addition, no unit tests applicable. This addresses bug OOZIE-758 . https://issues.apache.org/jira/browse/OOZIE-758 Diffs ----- trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1301249 Diff: https://reviews.apache.org/r/4378/diff Testing ------- Thanks, Mona
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-03-16 04:24:12, Alejandro Abdelnur wrote:

        > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java, line 170

        > <https://reviews.apache.org/r/4378/diff/1/?file=92894#file92894line170>

        >

        > Shouldn't the message just be 'Workflow submitted'? the loginfo will have the ID

        The ID was not getting added through the loginfo. It is due to the way a SubmitXCommand constructor is invoked, it does not have a jobID at that point and does not override 'loadState' like other start commands. So this statement is added.

        • Mona

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4378/#review6021
        -----------------------------------------------------------

        On 2012-03-16 04:19:15, Mona Chitnis wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4378/

        -----------------------------------------------------------

        (Updated 2012-03-16 04:19:15)

        Review request for oozie.

        Summary

        -------

        The job Id was not being recorded to oozie.log if the job was submited with option -submit instead of -run. This helps filtering through the logs for submitted jobs.

        Since this is a logging addition, no unit tests applicable.

        This addresses bug OOZIE-758.

        https://issues.apache.org/jira/browse/OOZIE-758

        Diffs

        -----

        trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1301249

        Diff: https://reviews.apache.org/r/4378/diff

        Testing

        -------

        Thanks,

        Mona

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-03-16 04:24:12, Alejandro Abdelnur wrote: > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java, line 170 > < https://reviews.apache.org/r/4378/diff/1/?file=92894#file92894line170 > > > Shouldn't the message just be 'Workflow submitted'? the loginfo will have the ID The ID was not getting added through the loginfo. It is due to the way a SubmitXCommand constructor is invoked, it does not have a jobID at that point and does not override 'loadState' like other start commands. So this statement is added. Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4378/#review6021 ----------------------------------------------------------- On 2012-03-16 04:19:15, Mona Chitnis wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4378/ ----------------------------------------------------------- (Updated 2012-03-16 04:19:15) Review request for oozie. Summary ------- The job Id was not being recorded to oozie.log if the job was submited with option -submit instead of -run. This helps filtering through the logs for submitted jobs. Since this is a logging addition, no unit tests applicable. This addresses bug OOZIE-758 . https://issues.apache.org/jira/browse/OOZIE-758 Diffs ----- trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1301249 Diff: https://reviews.apache.org/r/4378/diff Testing ------- Thanks, Mona
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4378/#review6021
        -----------------------------------------------------------

        trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java
        <https://reviews.apache.org/r/4378/#comment13009>

        Shouldn't the message just be 'Workflow submitted'? the loginfo will have the ID

        • Alejandro

        On 2012-03-16 04:19:15, Mona Chitnis wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4378/

        -----------------------------------------------------------

        (Updated 2012-03-16 04:19:15)

        Review request for oozie.

        Summary

        -------

        The job Id was not being recorded to oozie.log if the job was submited with option -submit instead of -run. This helps filtering through the logs for submitted jobs.

        Since this is a logging addition, no unit tests applicable.

        This addresses bug OOZIE-758.

        https://issues.apache.org/jira/browse/OOZIE-758

        Diffs

        -----

        trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1301249

        Diff: https://reviews.apache.org/r/4378/diff

        Testing

        -------

        Thanks,

        Mona

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4378/#review6021 ----------------------------------------------------------- trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java < https://reviews.apache.org/r/4378/#comment13009 > Shouldn't the message just be 'Workflow submitted'? the loginfo will have the ID Alejandro On 2012-03-16 04:19:15, Mona Chitnis wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4378/ ----------------------------------------------------------- (Updated 2012-03-16 04:19:15) Review request for oozie. Summary ------- The job Id was not being recorded to oozie.log if the job was submited with option -submit instead of -run. This helps filtering through the logs for submitted jobs. Since this is a logging addition, no unit tests applicable. This addresses bug OOZIE-758 . https://issues.apache.org/jira/browse/OOZIE-758 Diffs ----- trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1301249 Diff: https://reviews.apache.org/r/4378/diff Testing ------- Thanks, Mona
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4378/
        -----------------------------------------------------------

        Review request for oozie.

        Summary
        -------

        The job Id was not being recorded to oozie.log if the job was submited with option -submit instead of -run. This helps filtering through the logs for submitted jobs.

        Since this is a logging addition, no unit tests applicable.

        This addresses bug OOZIE-758.
        https://issues.apache.org/jira/browse/OOZIE-758

        Diffs


        trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1301249

        Diff: https://reviews.apache.org/r/4378/diff

        Testing
        -------

        Thanks,

        Mona

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4378/ ----------------------------------------------------------- Review request for oozie. Summary ------- The job Id was not being recorded to oozie.log if the job was submited with option -submit instead of -run. This helps filtering through the logs for submitted jobs. Since this is a logging addition, no unit tests applicable. This addresses bug OOZIE-758 . https://issues.apache.org/jira/browse/OOZIE-758 Diffs trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1301249 Diff: https://reviews.apache.org/r/4378/diff Testing ------- Thanks, Mona

          People

          • Assignee:
            Unassigned
            Reporter:
            Mona Chitnis
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development