Oozie
  1. Oozie
  2. OOZIE-480

OOZIE-63: In Oozie-site.xml, if we specify oozie.services.ext property is not overriding the services.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.2.0
    • Component/s: None
    • Labels:
      None

      Description

      In Oozie-site.xml, if we specify oozie.services.ext property is not overriding the services.

        Activity

        Hide
        Alejandro Abdelnur added a comment -

        The issue here is that is a service is overridden in as an extension, the original one is loaded first and then discarded.

        The correct logic should be to resolve all services first by interface and then load the final ones.

        Show
        Alejandro Abdelnur added a comment - The issue here is that is a service is overridden in as an extension, the original one is loaded first and then discarded. The correct logic should be to resolve all services first by interface and then load the final ones.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2802/
        -----------------------------------------------------------

        Review request for oozie.

        Summary
        -------

        The patch loads all services classes, initializes them to find out the service interface and keeps the latest one, after that only the final ones are initialized.

        This will address the problem of the HadoopAccessorService/KerberosAccessorService

        This addresses bug OOZIE-480.
        https://issues.apache.org/jira/browse/OOZIE-480

        Diffs


        /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1200683
        /trunk/core/src/main/java/org/apache/oozie/service/Services.java 1200683
        /trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1200683

        Diff: https://reviews.apache.org/r/2802/diff

        Testing
        -------

        Thanks,

        Alejandro

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2802/ ----------------------------------------------------------- Review request for oozie. Summary ------- The patch loads all services classes, initializes them to find out the service interface and keeps the latest one, after that only the final ones are initialized. This will address the problem of the HadoopAccessorService/KerberosAccessorService This addresses bug OOZIE-480 . https://issues.apache.org/jira/browse/OOZIE-480 Diffs /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1200683 /trunk/core/src/main/java/org/apache/oozie/service/Services.java 1200683 /trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1200683 Diff: https://reviews.apache.org/r/2802/diff Testing ------- Thanks, Alejandro
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2802/#review3202
        -----------------------------------------------------------

        Pls add a release.log entry.

        /trunk/core/src/main/java/org/apache/oozie/service/Services.java
        <https://reviews.apache.org/r/2802/#comment7100>

        Although the last one is replacing, the first one is also initialized (in line 237).

        Alternatively, can't we do the replacement before instantiation of the replaced service class. Wandering if that could create any side-effect.

        • Mohammad

        On 2011-11-11 01:32:42, Alejandro Abdelnur wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2802/

        -----------------------------------------------------------

        (Updated 2011-11-11 01:32:42)

        Review request for oozie.

        Summary

        -------

        The patch loads all services classes, initializes them to find out the service interface and keeps the latest one, after that only the final ones are initialized.

        This will address the problem of the HadoopAccessorService/KerberosAccessorService

        This addresses bug OOZIE-480.

        https://issues.apache.org/jira/browse/OOZIE-480

        Diffs

        -----

        /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1200683

        /trunk/core/src/main/java/org/apache/oozie/service/Services.java 1200683

        /trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1200683

        Diff: https://reviews.apache.org/r/2802/diff

        Testing

        -------

        Thanks,

        Alejandro

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2802/#review3202 ----------------------------------------------------------- Pls add a release.log entry. /trunk/core/src/main/java/org/apache/oozie/service/Services.java < https://reviews.apache.org/r/2802/#comment7100 > Although the last one is replacing, the first one is also initialized (in line 237). Alternatively, can't we do the replacement before instantiation of the replaced service class. Wandering if that could create any side-effect. Mohammad On 2011-11-11 01:32:42, Alejandro Abdelnur wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2802/ ----------------------------------------------------------- (Updated 2011-11-11 01:32:42) Review request for oozie. Summary ------- The patch loads all services classes, initializes them to find out the service interface and keeps the latest one, after that only the final ones are initialized. This will address the problem of the HadoopAccessorService/KerberosAccessorService This addresses bug OOZIE-480 . https://issues.apache.org/jira/browse/OOZIE-480 Diffs ----- /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1200683 /trunk/core/src/main/java/org/apache/oozie/service/Services.java 1200683 /trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1200683 Diff: https://reviews.apache.org/r/2802/diff Testing ------- Thanks, Alejandro
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2011-11-14 07:25:55, Mohammad Islam wrote:

        > Pls add a release.log entry.

        Wouldn't make more sense (as it is done in Hadoop as well) that the committer edits the release log at commit time?

        This would avoid unnecessary conflicts when patches are committed out of order.

        On 2011-11-14 07:25:55, Mohammad Islam wrote:

        > /trunk/core/src/main/java/org/apache/oozie/service/Services.java, line 284

        > <https://reviews.apache.org/r/2802/diff/1/?file=57459#file57459line284>

        >

        > Although the last one is replacing, the first one is also initialized (in line 237).

        >

        > Alternatively, can't we do the replacement before instantiation of the replaced service class. Wandering if that could create any side-effect.

        not possible to do so as we need to instantiate the service to find the interface it implements.

        • Alejandro

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2802/#review3202
        -----------------------------------------------------------

        On 2011-11-11 01:32:42, Alejandro Abdelnur wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2802/

        -----------------------------------------------------------

        (Updated 2011-11-11 01:32:42)

        Review request for oozie.

        Summary

        -------

        The patch loads all services classes, initializes them to find out the service interface and keeps the latest one, after that only the final ones are initialized.

        This will address the problem of the HadoopAccessorService/KerberosAccessorService

        This addresses bug OOZIE-480.

        https://issues.apache.org/jira/browse/OOZIE-480

        Diffs

        -----

        /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1200683

        /trunk/core/src/main/java/org/apache/oozie/service/Services.java 1200683

        /trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1200683

        Diff: https://reviews.apache.org/r/2802/diff

        Testing

        -------

        Thanks,

        Alejandro

        Show
        jiraposter@reviews.apache.org added a comment - On 2011-11-14 07:25:55, Mohammad Islam wrote: > Pls add a release.log entry. Wouldn't make more sense (as it is done in Hadoop as well) that the committer edits the release log at commit time? This would avoid unnecessary conflicts when patches are committed out of order. On 2011-11-14 07:25:55, Mohammad Islam wrote: > /trunk/core/src/main/java/org/apache/oozie/service/Services.java, line 284 > < https://reviews.apache.org/r/2802/diff/1/?file=57459#file57459line284 > > > Although the last one is replacing, the first one is also initialized (in line 237). > > Alternatively, can't we do the replacement before instantiation of the replaced service class. Wandering if that could create any side-effect. not possible to do so as we need to instantiate the service to find the interface it implements. Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2802/#review3202 ----------------------------------------------------------- On 2011-11-11 01:32:42, Alejandro Abdelnur wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2802/ ----------------------------------------------------------- (Updated 2011-11-11 01:32:42) Review request for oozie. Summary ------- The patch loads all services classes, initializes them to find out the service interface and keeps the latest one, after that only the final ones are initialized. This will address the problem of the HadoopAccessorService/KerberosAccessorService This addresses bug OOZIE-480 . https://issues.apache.org/jira/browse/OOZIE-480 Diffs ----- /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1200683 /trunk/core/src/main/java/org/apache/oozie/service/Services.java 1200683 /trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1200683 Diff: https://reviews.apache.org/r/2802/diff Testing ------- Thanks, Alejandro
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2802/
        -----------------------------------------------------------

        (Updated 2011-11-15 06:48:22.623611)

        Review request for oozie.

        Changes
        -------

        setting the boolean flags in the test to FALSE at the beginning of the test as the order of execution of test methods is not deterministic and one of the test services is used in another test

        Summary
        -------

        The patch loads all services classes, initializes them to find out the service interface and keeps the latest one, after that only the final ones are initialized.

        This will address the problem of the HadoopAccessorService/KerberosAccessorService

        This addresses bug OOZIE-480.
        https://issues.apache.org/jira/browse/OOZIE-480

        Diffs (updated)


        /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1202059
        /trunk/core/src/main/java/org/apache/oozie/service/Services.java 1202059
        /trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1202059

        Diff: https://reviews.apache.org/r/2802/diff

        Testing
        -------

        Thanks,

        Alejandro

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2802/ ----------------------------------------------------------- (Updated 2011-11-15 06:48:22.623611) Review request for oozie. Changes ------- setting the boolean flags in the test to FALSE at the beginning of the test as the order of execution of test methods is not deterministic and one of the test services is used in another test Summary ------- The patch loads all services classes, initializes them to find out the service interface and keeps the latest one, after that only the final ones are initialized. This will address the problem of the HadoopAccessorService/KerberosAccessorService This addresses bug OOZIE-480 . https://issues.apache.org/jira/browse/OOZIE-480 Diffs (updated) /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1202059 /trunk/core/src/main/java/org/apache/oozie/service/Services.java 1202059 /trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1202059 Diff: https://reviews.apache.org/r/2802/diff Testing ------- Thanks, Alejandro
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2802/#review3248
        -----------------------------------------------------------

        Ship it!

        +1

        • Mohammad

        On 2011-11-15 06:48:22, Alejandro Abdelnur wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2802/

        -----------------------------------------------------------

        (Updated 2011-11-15 06:48:22)

        Review request for oozie.

        Summary

        -------

        The patch loads all services classes, initializes them to find out the service interface and keeps the latest one, after that only the final ones are initialized.

        This will address the problem of the HadoopAccessorService/KerberosAccessorService

        This addresses bug OOZIE-480.

        https://issues.apache.org/jira/browse/OOZIE-480

        Diffs

        -----

        /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1202059

        /trunk/core/src/main/java/org/apache/oozie/service/Services.java 1202059

        /trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1202059

        Diff: https://reviews.apache.org/r/2802/diff

        Testing

        -------

        Thanks,

        Alejandro

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2802/#review3248 ----------------------------------------------------------- Ship it! +1 Mohammad On 2011-11-15 06:48:22, Alejandro Abdelnur wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2802/ ----------------------------------------------------------- (Updated 2011-11-15 06:48:22) Review request for oozie. Summary ------- The patch loads all services classes, initializes them to find out the service interface and keeps the latest one, after that only the final ones are initialized. This will address the problem of the HadoopAccessorService/KerberosAccessorService This addresses bug OOZIE-480 . https://issues.apache.org/jira/browse/OOZIE-480 Diffs ----- /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1202059 /trunk/core/src/main/java/org/apache/oozie/service/Services.java 1202059 /trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1202059 Diff: https://reviews.apache.org/r/2802/diff Testing ------- Thanks, Alejandro
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2011-11-14 07:25:55, Mohammad Islam wrote:

        > Pls add a release.log entry.

        Alejandro Abdelnur wrote:

        Wouldn't make more sense (as it is done in Hadoop as well) that the committer edits the release log at commit time?

        This would avoid unnecessary conflicts when patches are committed out of order.

        So we can adopt the same policy as followed in hadoop. No release log entry is needed. The committer will add one.
        I agree it will reduce the # of conflicts.

        • Mohammad

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2802/#review3202
        -----------------------------------------------------------

        On 2011-11-15 06:48:22, Alejandro Abdelnur wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2802/

        -----------------------------------------------------------

        (Updated 2011-11-15 06:48:22)

        Review request for oozie.

        Summary

        -------

        The patch loads all services classes, initializes them to find out the service interface and keeps the latest one, after that only the final ones are initialized.

        This will address the problem of the HadoopAccessorService/KerberosAccessorService

        This addresses bug OOZIE-480.

        https://issues.apache.org/jira/browse/OOZIE-480

        Diffs

        -----

        /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1202059

        /trunk/core/src/main/java/org/apache/oozie/service/Services.java 1202059

        /trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1202059

        Diff: https://reviews.apache.org/r/2802/diff

        Testing

        -------

        Thanks,

        Alejandro

        Show
        jiraposter@reviews.apache.org added a comment - On 2011-11-14 07:25:55, Mohammad Islam wrote: > Pls add a release.log entry. Alejandro Abdelnur wrote: Wouldn't make more sense (as it is done in Hadoop as well) that the committer edits the release log at commit time? This would avoid unnecessary conflicts when patches are committed out of order. So we can adopt the same policy as followed in hadoop. No release log entry is needed. The committer will add one. I agree it will reduce the # of conflicts. Mohammad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2802/#review3202 ----------------------------------------------------------- On 2011-11-15 06:48:22, Alejandro Abdelnur wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2802/ ----------------------------------------------------------- (Updated 2011-11-15 06:48:22) Review request for oozie. Summary ------- The patch loads all services classes, initializes them to find out the service interface and keeps the latest one, after that only the final ones are initialized. This will address the problem of the HadoopAccessorService/KerberosAccessorService This addresses bug OOZIE-480 . https://issues.apache.org/jira/browse/OOZIE-480 Diffs ----- /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1202059 /trunk/core/src/main/java/org/apache/oozie/service/Services.java 1202059 /trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1202059 Diff: https://reviews.apache.org/r/2802/diff Testing ------- Thanks, Alejandro

          People

          • Assignee:
            Alejandro Abdelnur
            Reporter:
            Mayank Bansal
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development