Details
-
Improvement
-
Status: Open
-
Major
-
Resolution: Unresolved
-
None
-
None
-
None
-
None
Description
OOZIE-1890 addressed the issues of config default values with the following steps:
- make oozie-site.xml empty
- put (almost) all configuration from oozie-default.xml
- remove default values from the code
It left the following confusing text at the beginning of the oozie-default.xml site:
This file is in the Oozie configuration directory only for reference. It is not loaded by Oozie, Oozie uses its own privatecopy.
Maybe it's referring to the oozie-site.xml or assumes that all the default values are specified in the code. I think this text is misleading, we should delete it.
Although OOZIE-1890 removed all the defaults from the source code (replacing code like getInt(name, defaultValue) with getInt(name)) later defaults were introduced again into the code.
I think we need to revisit the issue again:
- remove default values from the code
- modify ConfigurationService to avoid using default values in the code (at least make those methods deprecated, maybe throw IllegalArgumentException but I'm afraid that would be too strict.
Attachments
Issue Links
- relates to
-
OOZIE-2338 Invalid configuration defined reported for some valid configs
- Patch Available