[OOZIE-3417] [FS Action] Refactor and optimize FsActionExecutor.java decision making part

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.2.0
• Fix Version/s: 5.2.0
• Component/s: core
• Labels: performance
• Assignee: xiong duan
• Reporter: xiong duan
• Created: 12/Jan/19 02:18
• Updated: 09/Dec/19 08:53
• Resolved: 30/Jan/19 09:56

Description

When I read FsActionExecutor.java, I found a not good code in this class.  When judging which logic to use based on commands, should use "switch/case" replace "if/else":

1. “if/else” make the code hard to read
2. “if/else” make the code hard to extend
3. “if/else” has low  efficience

So I suggest using “switch/case” instead.

Issue Links

• links to: Review Board