[OOZIE-3407] [tests] Cleanup TestPurgeXCommand

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.1.0
• Fix Version/s: 5.2.0
• Component/s: tests
• Assignee: Andras Salamon
• Reporter: Andras Salamon
• Created: 19/Dec/18 11:11
• Updated: 09/Dec/19 08:54
• Resolved: 10/Jan/19 15:37

Description

TestPurgeXCommand is the longest java source file of Oozie, more than 4000 rows.

As part of the Purge Service rewrite we need to use this file to make sure we don't introduce new bugs and probably we also need to add a few more test cases. Before that it would be useful to cleanup this file and extract redundant code to new methods to make the code shorter and more manageable.

The patch uploaded to OOZIE-3400 introduced three new test cases to this file and shows a simple way to make it shorter.

Issue Links

• is blocked by: OOZIE-3400 [core] Fix PurgeService sub-sub-workflow checking
• relates to: OOZIE-3252 Flaky TestPurgeXCommand methods
• links to: Review Board