Uploaded image for project: 'Oozie'
  1. Oozie
  2. OOZIE-3399

[tests] Eliminate nested class in TestV1JobsServletBundleEngine and TestV1JobServletBundleEngine

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • trunk
    • 5.2.0
    • tests
    • None

    Description

      There is a useless nested class in TestV1JobsServletBundleEngine and TestV1JobServletBundleEngine:

      /**
           * This class is needed in order to reuse some methods of class {@link XDataTestCase}. We cannot directly extend it there as
           * we extend {@link DagServletTestCase}. Anonymous inner class is also not an option since we cannot assign it an annotation.
           * The @Ignore annotation is needed to prevent JUnit from recognizing this inner class as a test.
           */
          @Ignore
          private static class XDataTestCase1 extends XDataTestCase {
          }
      

      The comment is no longer relevant, the classes extend DagServletTestCase which extends XDataTestCase, no need for the nested class.

      I'm not able to reproduce it, but I find more than suspicious that different tests fail in the precommit unit tests right after the unit test runs (and ignores) the XDataTestCase1 nested class. Maybe the double initialization of XDataTestCase causes some problems:

      https://builds.apache.org/job/PreCommit-OOZIE-Build/938/consoleFull
      https://builds.apache.org/job/PreCommit-OOZIE-Build/940/consoleFull
      https://builds.apache.org/job/PreCommit-OOZIE-Build/941/consoleFull

      Attachments

        1. OOZIE-3399-01.patch
          7 kB
          Andras Salamon

        Activity

          People

            asalamon74 Andras Salamon
            asalamon74 Andras Salamon
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: