[OOZIE-3340] [fluent-job] Create error handler ACTION only if needed

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.1.0
• Component/s: fluent-job
• Assignee: Kinga Marton
• Reporter: Andras Salamon
• Created: 10/Sep/18 11:13
• Updated: 18/Jan/19 08:59
• Resolved: 26/Sep/18 12:59

Description

The Shell and MultipleShellActions example of the Fluent Job API generates multiple actions with the same name (email-on-error) which gives E0705 error code.

For MultipleShellActions the generated XML:

Workflow job definition generated from API jar: 
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<workflow:workflow-app xmlns:email="uri:oozie:email-action:0.2" xmlns:workflow="uri:oozie:workflow:1.0" xmlns:shell="uri:oozie:shell-action:1.0" name="shell-example">
    <workflow:start to="parent"/>
    <workflow:kill name="kill">
        <workflow:message>Action failed, error message[${wf:errorMessage(wf:lastErrorNode())}]</workflow:message>
    </workflow:kill>
    <workflow:action name="email-on-error">
        <email:email>
            <email:to>[e-mail]</email:to>
            <email:subject>Workflow error</email:subject>
            <email:body>Shell action failed, error message[${wf:errorMessage(wf:lastErrorNode())}]</email:body>
        </email:email>
        <workflow:ok to="kill"/>
        <workflow:error to="kill"/>
    </workflow:action>
    <workflow:action name="parent">
        ...
    </workflow:action>
    <workflow:decision name="decision1">
       ...
    </workflow:decision>
    <workflow:action name="email-on-error">
        ...
    </workflow:action>
    <workflow:action name="happy-path-0">
        ...
    </workflow:action>
    <workflow:decision name="decision2">
        ...
    </workflow:action>
    ...

The error message:

bin/oozie job -oozie http://localhost:11000/oozie -runjar fluenttest.jar -config job.properties -verbose
...
Error: E0705 : E0705: Nnode already defined, node [email-on-error]

The Shell example also creates an XML with multiple email-on-error actions.

Issue Links

• links to: ReviewBoard review request