Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1.0
    • Component/s: None
    • Labels:

      Description

      There are some [tTrim] functions across our codebase:

      171-     * @return the formatted time string.
      >> [350] 14:20 : oozie (cdh6.x) :: ack -C8 --type=java "[tT]rim\(String"
      core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProviderFactory.java
      89-    }
      90-
      91-    /**
      92-     * To trim string
      93-     *
      94-     * @param str
      95-     * @return trim string
      96-     */
      97:    public String trim(String str) {
      98-        if (str != null) {
      99-            str = str.replaceAll("\\n", "");
      100-            str = str.replaceAll("\\t", "");
      101-            str = str.trim();
      102-        }
      103-        return str;
      104-    }
      105-}
      
      core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java
      81-    }
      82-
      83-    /**
      84-     * To trim string
      85-     *
      86-     * @param str
      87-     * @return trim string
      88-     */
      89:    public static String Trim(String str) {
      90-        if (str != null) {
      91-            str = str.replaceAll("\\n", "");
      92-            str = str.replaceAll("\\t", "");
      93-            str = str.trim();
      94-        }
      95-        return str;
      96-    }
      97-
      

      The purpose of these functions is to clean up input from xml files.
      They should be consolidated to one place.
      There might be a similar method in Hadoop, we should use that.

        Attachments

          Activity

            People

            • Assignee:
              Jan Hentschel Jan Hentschel
              Reporter:
              gezapeti Peter Cseh
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: