[OOZIE-2532] patch apply does not handle binary files

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.3.0
• Assignee: Gézapeti
• Reporter: Gézapeti
• Created: 17/May/16 16:53
• Updated: 09/Mar/17 18:42
• Resolved: 25/May/16 02:36

Description

In OOZIE-2482 there is a patch which contains binary files as well.
After running

patch -E -p0 <~/Downloads/OOZIE-2482-2.patch

the folder sharelib/spark/src/test/resources contains only pi.py, and not the zip files.

git apply -p0 <~/Downloads/OOZIE-2482-2.patch

processes the binary part of the patch as well.
Git documentation claims that patches created with --binary can be applied with git apply, I assume they know that it's not compatible with the patch command.

Should we change this in the Jenkins job or we should keep this behavior as a gatekeeper to prevent binary files committed to master?

Issue Links

• is duplicated by: OOZIE-2304 update test-patch to work with p0 and p1
• is related to: OOZIE-2482 Pyspark job fails with Oozie
• relates to: OOZIE-2099 Add test-patch support for patches generated without --no-prefix