[OOZIE-2462] When calling ParamChecker.notNull() in CoordActionsIgnoreXCommand.java, "Action" should be passed instead of "Action cannot be null".

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 4.3.0
• Labels: newbie
• Assignee: Manjunath Ballur
• Reporter: Manjunath Ballur
• Created: 22/Feb/16 05:28
• Updated: 02/Dec/16 21:03
• Resolved: 20/Jul/16 06:38

Description

In ParamChecker::notNull() method, if the passed object is null, then following exception is thrown:

if (obj == null)

{ throw new IllegalArgumentException(name + " cannot be null"); }

Here, "name" is the name of the object being checked.

In "CoordActionsIgnoreXCommand::checkAllActionsStatus()" method, following piece of code calls "ParamChecker::notNull()" method:

ParamChecker.notNull(action, "Action cannot be null");

The above statement should be changed to:
ParamChecker.notNull(action, "Action");

With the current code, when "action" is null, then the message printed will be:
"Action cannot be null cannot be null"

"cannot be null" is printed twice.
Hence, we need to remove "cannot be null" while calling "ParamChecker::notNull()" method.