Uploaded image for project: 'Oozie'
  1. Oozie
  2. OOZIE-2462

When calling ParamChecker.notNull() in CoordActionsIgnoreXCommand.java, "Action" should be passed instead of "Action cannot be null".

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.0
    • Component/s: None
    • Labels:

      Description

      In ParamChecker::notNull() method, if the passed object is null, then following exception is thrown:

      if (obj == null)

      { throw new IllegalArgumentException(name + " cannot be null"); }

      Here, "name" is the name of the object being checked.

      In "CoordActionsIgnoreXCommand::checkAllActionsStatus()" method, following piece of code calls "ParamChecker::notNull()" method:

      ParamChecker.notNull(action, "Action cannot be null");

      The above statement should be changed to:
      ParamChecker.notNull(action, "Action");

      With the current code, when "action" is null, then the message printed will be:
      "Action cannot be null cannot be null"

      "cannot be null" is printed twice.
      Hence, we need to remove "cannot be null" while calling "ParamChecker::notNull()" method.

        Attachments

        1. OOZIE-2462-002.patch
          1 kB
          Manjunath Ballur
        2. OOZIE-2462-002.patch
          1 kB
          Manjunath Ballur
        3. OOZIE-2462-001.patch
          1 kB
          Manjunath Ballur

          Activity

            People

            • Assignee:
              mballur Manjunath Ballur
              Reporter:
              mballur Manjunath Ballur
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: