Uploaded image for project: 'Oozie'
  1. Oozie
  2. OOZIE-2376

Default action configs not honored if no <configuration> section in workflow

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: 4.3.0
    • Component/s: None
    • Labels:
      None

      Description

      If you use oozie.service.HadoopAccessorService.action.configurations to specify a default configuration, and your action doesn't have a <configuration> section, Oozie won't insert the default configs into the launcher job. It should always insert them.

        Activity

        Hide
        rkanter Robert Kanter added a comment -

        Closing issue; Oozie 4.3.0 is released.

        Show
        rkanter Robert Kanter added a comment - Closing issue; Oozie 4.3.0 is released.
        Hide
        rkanter Robert Kanter added a comment -

        Thanks for the review Rohini. Committed to trunk!

        Show
        rkanter Robert Kanter added a comment - Thanks for the review Rohini. Committed to trunk!
        Hide
        rkanter Robert Kanter added a comment -

        Test failure unrelated

        Show
        rkanter Robert Kanter added a comment - Test failure unrelated
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA OOZIE-2376

        Cleaning local git workspace

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        +1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 132
        . +1 the patch does adds/modifies 1 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 BACKWARDS_COMPATIBILITY
        . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
        . +1 the patch does not modify JPA files
        -1 TESTS
        . Tests run: 1695
        . Tests failed: 1
        . Tests errors: 0

        . The patch failed the following testcases:

        . testForNoDuplicates(org.apache.oozie.event.TestEventGeneration)

        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/oozie-trunk-precommit-build/2558/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2376 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . +1 the patch does adds/modifies 1 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 1695 . Tests failed: 1 . Tests errors: 0 . The patch failed the following testcases: . testForNoDuplicates(org.apache.oozie.event.TestEventGeneration) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/2558/
        Hide
        rohini Rohini Palaniswamy added a comment -

        +1

        Show
        rohini Rohini Palaniswamy added a comment - +1
        Hide
        rkanter Robert Kanter added a comment -

        The patch mostly moves and dedupes some code around in how the default configs are added to the launcher job. Previously, they were only done so in an if statement that checked for the existence of <configuration>, which is why this was broken before. I also added a unit test.

        Show
        rkanter Robert Kanter added a comment - The patch mostly moves and dedupes some code around in how the default configs are added to the launcher job. Previously, they were only done so in an if statement that checked for the existence of <configuration> , which is why this was broken before. I also added a unit test.

          People

          • Assignee:
            rkanter Robert Kanter
            Reporter:
            rkanter Robert Kanter
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development