Uploaded image for project: 'Oozie'
  1. Oozie
  2. OOZIE-2225

Add wild card filter for gathering jobs

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.1.0
    • Fix Version/s: 5.0.0b1
    • Component/s: core
    • Labels:
      None

      Description

      Oozie currently supports name, user, group, status, frequency and unit as filter params.

      Add wild card param that matches partially with name/user or complete match with ID

      1. OOZIE-2225-001.patch
        16 kB
        Sai Chirravuri
      2. OOZIE-2225-002.patch
        18 kB
        Sai Chirravuri
      3. OOZIE-2225-003.patch
        20 kB
        Sai Chirravuri
      4. OOZIE-2225-004.patch
        19 kB
        Sai Chirravuri
      5. OOZIE-2225-005.patch
        23 kB
        Sai Chirravuri
      6. OOZIE-2225-007.patch
        26 kB
        Sai Chirravuri
      7. OOZIE-2225-008.patch
        27 kB
        Sai Chirravuri
      8. OOZIE-2225-009.patch
        27 kB
        Sai Chirravuri
      9. OOZIE-2225-010.patch
        26 kB
        Sai Chirravuri
      10. OOZIE-2225-amend-001.patch
        7 kB
        Peter Bacsko
      11. OOZIE-2225-amend-002.patch
        7 kB
        Peter Bacsko
      12. OOZIE-2225-amend-003.patch
        13 kB
        Peter Bacsko
      13. OOZIE-2225-amend-004.patch
        7 kB
        Peter Bacsko

        Activity

        Hide
        sai-krish Sai Chirravuri added a comment -

        This patch adds a new filter option 'text' to any oozie job.

        A query with text='asdf' would return all the jobs which satisfy ANY of the following conditions.
        1. job.name.contains(text)
        2. job.user.contains(text)
        3. job.id = text

        Show
        sai-krish Sai Chirravuri added a comment - This patch adds a new filter option 'text' to any oozie job. A query with text='asdf' would return all the jobs which satisfy ANY of the following conditions. 1. job.name.contains(text) 2. job.user.contains(text) 3. job.id = text
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA OOZIE-2225

        Cleaning local git workspace

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . -1 the patch contains 1 line(s) longer than 132 characters
        . +1 the patch does adds/modifies 4 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        -1 COMPILE
        . +1 HEAD compiles
        . -1 patch does not compile
        . +1 the patch does not seem to introduce new javac warnings
        +1 BACKWARDS_COMPATIBILITY
        . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
        . +1 the patch does not modify JPA files
        -1 TESTS - patch does not compile, cannot run testcases
        -1 DISTRO
        . -1 distro tarball fails with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/oozie-trunk-precommit-build/2850/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2225 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . -1 the patch contains 1 line(s) longer than 132 characters . +1 the patch does adds/modifies 4 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings -1 COMPILE . +1 HEAD compiles . -1 patch does not compile . +1 the patch does not seem to introduce new javac warnings +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS - patch does not compile, cannot run testcases -1 DISTRO . -1 distro tarball fails with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/2850/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA OOZIE-2225

        Cleaning local git workspace

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . -1 the patch contains 3 line(s) longer than 132 characters
        . +1 the patch does adds/modifies 4 testcase(s)
        -1 RAT
        . -1 the patch seems to introduce 1 new RAT warning(s)
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 BACKWARDS_COMPATIBILITY
        . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
        . +1 the patch does not modify JPA files
        -1 TESTS
        . Tests run: 1777
        . Tests failed: 0
        . Tests errors: 1

        . The patch failed the following testcases:

        .

        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/oozie-trunk-precommit-build/2851/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2225 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . -1 the patch contains 3 line(s) longer than 132 characters . +1 the patch does adds/modifies 4 testcase(s) -1 RAT . -1 the patch seems to introduce 1 new RAT warning(s) +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 1777 . Tests failed: 0 . Tests errors: 1 . The patch failed the following testcases: . +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/2851/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA OOZIE-2225

        Cleaning local git workspace

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . -1 the patch contains 1 line(s) longer than 132 characters
        . +1 the patch does adds/modifies 4 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 BACKWARDS_COMPATIBILITY
        . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
        . +1 the patch does not modify JPA files
        +1 TESTS
        . Tests run: 1777
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/oozie-trunk-precommit-build/2853/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2225 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . -1 the patch contains 1 line(s) longer than 132 characters . +1 the patch does adds/modifies 4 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files +1 TESTS . Tests run: 1777 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/2853/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA OOZIE-2225

        Cleaning local git workspace

        ----------------------------

        -1 Patch failed to apply to head of branch

        ----------------------------

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2225 Cleaning local git workspace ---------------------------- -1 Patch failed to apply to head of branch ----------------------------
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA OOZIE-2225

        Cleaning local git workspace

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        +1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 132
        . +1 the patch does adds/modifies 4 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 BACKWARDS_COMPATIBILITY
        . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
        . +1 the patch does not modify JPA files
        +1 TESTS
        . Tests run: 1792
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        +1 Overall result, good!, no -1s

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/oozie-trunk-precommit-build/3212/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2225 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . +1 the patch does adds/modifies 4 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files +1 TESTS . Tests run: 1792 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- +1 Overall result, good!, no -1s The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/3212/
        Hide
        jaydeepvishwakarma Jaydeep Vishwakarma added a comment -

        Can you please upload it to review board.

        Show
        jaydeepvishwakarma Jaydeep Vishwakarma added a comment - Can you please upload it to review board.
        Hide
        rkanter Robert Kanter added a comment -

        I haven't had a chance to try it out yet, but here's a few comments from going through the code:

        • Update the CLI/Oozie client and to be able to use this
        • Update the Web Services and CLI docs
        • Why do we need to change valArray from List<String> type to List<Object> type?
        • In a few of the tests, you use the below pattern. You should put a fail("msg") after the jpaService call in case it doesn't throw an Exception we'll want to fail the test.
          +        try{
          +            jpaService.execute(bundleInfoGetCmd);
          +        } catch (XException e) {
          +            assertEquals(ErrorCode.E0302, e.getErrorCode());
          +        }
          
        Show
        rkanter Robert Kanter added a comment - I haven't had a chance to try it out yet, but here's a few comments from going through the code: Update the CLI/Oozie client and to be able to use this Update the Web Services and CLI docs Why do we need to change valArray from List<String> type to List<Object> type? In a few of the tests, you use the below pattern. You should put a fail("msg") after the jpaService call in case it doesn't throw an Exception we'll want to fail the test. + try { + jpaService.execute(bundleInfoGetCmd); + } catch (XException e) { + assertEquals(ErrorCode.E0302, e.getErrorCode()); + }
        Hide
        sai-krish Sai Chirravuri added a comment -

        Attached a new patch with the following changes

        + Web Services and CLI docs
        + Added fail() in the tests as suggested above.

        Oozie client did not need any changes
        valArray from List<String> type to List<Object> had to be done as it was also accepting DateTime objects

        Upstream review - https://reviews.apache.org/r/52227/

        Show
        sai-krish Sai Chirravuri added a comment - Attached a new patch with the following changes + Web Services and CLI docs + Added fail() in the tests as suggested above. Oozie client did not need any changes valArray from List<String> type to List<Object> had to be done as it was also accepting DateTime objects Upstream review - https://reviews.apache.org/r/52227/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA OOZIE-2225

        Cleaning local git workspace

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        +1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 132
        . +1 the patch does adds/modifies 4 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 BACKWARDS_COMPATIBILITY
        . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
        . +1 the patch does not modify JPA files
        -1 TESTS
        . Tests run: 1808
        . Tests failed: 2
        . Tests errors: 0

        . The patch failed the following testcases:

        . testIdSwapSubmitOK(org.apache.oozie.action.hadoop.TestJavaActionExecutor)
        . testNone(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommandNonUTC)

        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/oozie-trunk-precommit-build/3328/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2225 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . +1 the patch does adds/modifies 4 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 1808 . Tests failed: 2 . Tests errors: 0 . The patch failed the following testcases: . testIdSwapSubmitOK(org.apache.oozie.action.hadoop.TestJavaActionExecutor) . testNone(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommandNonUTC) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/3328/
        Hide
        sai-krish Sai Chirravuri added a comment -
        Show
        sai-krish Sai Chirravuri added a comment - updated the review - https://reviews.apache.org/r/52227/
        Hide
        abhishekbafna Abhishek Bafna added a comment -

        You should add the group field in the above RB. If you type 'oozie', it will auto complete it. Thanks.

        Show
        abhishekbafna Abhishek Bafna added a comment - You should add the group field in the above RB. If you type 'oozie', it will auto complete it. Thanks.
        Hide
        abhishekbafna Abhishek Bafna added a comment -

        Can you add the updated patch into Jira as well. Thanks. (I believe you have updated the review board only.)

        Show
        abhishekbafna Abhishek Bafna added a comment - Can you add the updated patch into Jira as well. Thanks. (I believe you have updated the review board only.)
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA OOZIE-2225

        Cleaning local git workspace

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        -1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . -1 the patch contains 1 line(s) longer than 132 characters
        . +1 the patch does adds/modifies 3 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 BACKWARDS_COMPATIBILITY
        . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
        . +1 the patch does not modify JPA files
        -1 TESTS
        . Tests run: 1818
        . Tests failed: 0
        . Tests errors: 1

        . The patch failed the following testcases:

        .

        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/oozie-trunk-precommit-build/3376/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2225 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . -1 the patch contains 1 line(s) longer than 132 characters . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 1818 . Tests failed: 0 . Tests errors: 1 . The patch failed the following testcases: . +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/3376/
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA OOZIE-2225

        Cleaning local git workspace

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        +1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 132
        . +1 the patch does adds/modifies 3 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        +1 BACKWARDS_COMPATIBILITY
        . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
        . +1 the patch does not modify JPA files
        -1 TESTS
        . Tests run: 1818
        . Tests failed: 1
        . Tests errors: 0

        . The patch failed the following testcases:

        . testActionKillCommandDate(org.apache.oozie.command.coord.TestCoordActionsKillXCommand)

        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/oozie-trunk-precommit-build/3385/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2225 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 1818 . Tests failed: 1 . Tests errors: 0 . The patch failed the following testcases: . testActionKillCommandDate(org.apache.oozie.command.coord.TestCoordActionsKillXCommand) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/3385/
        Hide
        sai-krish Sai Chirravuri added a comment -

        Failing case - org.apache.oozie.command.coord.TestCoordActionsKillXCommand
        runs fine locally on my machine and is unrelated to the code change.

        Show
        sai-krish Sai Chirravuri added a comment - Failing case - org.apache.oozie.command.coord.TestCoordActionsKillXCommand runs fine locally on my machine and is unrelated to the code change.
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA OOZIE-2225

        Cleaning local git workspace

        ----------------------------

        -1 Patch failed to apply to head of branch

        ----------------------------

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2225 Cleaning local git workspace ---------------------------- -1 Patch failed to apply to head of branch ----------------------------
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA OOZIE-2225

        Cleaning local git workspace

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        +1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 132
        . +1 the patch does adds/modifies 3 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        -1 FindBugs diff JAR has a weird MD5 sum, rejecting.
        +1 BACKWARDS_COMPATIBILITY
        . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
        . +1 the patch does not modify JPA files
        +1 TESTS
        . Tests run: 1818
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/oozie-trunk-precommit-build/3407/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2225 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings -1 FindBugs diff JAR has a weird MD5 sum, rejecting. +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files +1 TESTS . Tests run: 1818 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/3407/
        Hide
        rkanter Robert Kanter added a comment -

        +1

        Show
        rkanter Robert Kanter added a comment - +1
        Hide
        rkanter Robert Kanter added a comment -

        Thanks Sai Chirravuri. Committed to master!

        Show
        rkanter Robert Kanter added a comment - Thanks Sai Chirravuri . Committed to master!
        Hide
        pbacsko Peter Bacsko added a comment -

        I reopened the JIRA because using text + other filters together doesn't work.

        Show
        pbacsko Peter Bacsko added a comment - I reopened the JIRA because using text + other filters together doesn't work.
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA OOZIE-2225

        Cleaning local git workspace

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        +1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 132
        . +1 the patch does adds/modifies 3 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        -1 FindBugs diff JAR has a weird MD5 sum, rejecting.
        +1 BACKWARDS_COMPATIBILITY
        . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
        . +1 the patch does not modify JPA files
        +1 TESTS
        . Tests run: 1831
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/oozie-trunk-precommit-build/3445/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2225 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings -1 FindBugs diff JAR has a weird MD5 sum, rejecting. +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files +1 TESTS . Tests run: 1831 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/3445/
        Hide
        pbacsko Peter Bacsko added a comment -

        Rohini Palaniswamy,Purshotam Shah, Jaydeep Vishwakarma could you guys pls check the extension of the original patch & commit it upstream? Robert K. is out of office currently. Thanks!

        Show
        pbacsko Peter Bacsko added a comment - Rohini Palaniswamy , Purshotam Shah , Jaydeep Vishwakarma could you guys pls check the extension of the original patch & commit it upstream? Robert K. is out of office currently. Thanks!
        Hide
        jaydeepvishwakarma Jaydeep Vishwakarma added a comment -

        Peter Bacsko you do not need condition statement in following code.

        +                        if (!isEnabled) {
        +                            isEnabled = true;
        +                        }
        
        Show
        jaydeepvishwakarma Jaydeep Vishwakarma added a comment - Peter Bacsko you do not need condition statement in following code. + if (!isEnabled) { + isEnabled = true ; + }
        Hide
        abhishekbafna Abhishek Bafna added a comment -

        Jaydeep Vishwakarma It will be required, as isEnabled controls that seletStr should be added or not. In the case of FILTER_TEXT it is not updating the flag, it does uses the flag while prefixing seletStr into filterJobsUsingText method. Here is the wrong query it will generate otherwise.

        "Select w.id, w.appName, w.appPath, w.conf, w.statusStr, w.kickoffTimestamp, w.startTimestamp, w.endTimestamp, w.pauseTimestamp, w.createdTimestamp, w.user, w.group, w.timeUnitStr, w.timeOut from BundleJobBean w where (w.appName LIKE :text1 OR w.user LIKE :text2 OR w.id = :text3)Select w.id, w.appName, w.appPath, w.conf, w.statusStr, w.kickoffTimestamp, w.startTimestamp, w.endTimestamp, w.pauseTimestamp, w.createdTimestamp, w.user, w.group, w.timeUnitStr, w.timeOut from BundleJobBean w where w.statusStr IN (:status0) order by w.createdTimestamp desc".
        

        It has generated the two select query for status and text.

        Show
        abhishekbafna Abhishek Bafna added a comment - Jaydeep Vishwakarma It will be required, as isEnabled controls that seletStr should be added or not. In the case of FILTER_TEXT it is not updating the flag, it does uses the flag while prefixing seletStr into filterJobsUsingText method. Here is the wrong query it will generate otherwise. "Select w.id, w.appName, w.appPath, w.conf, w.statusStr, w.kickoffTimestamp, w.startTimestamp, w.endTimestamp, w.pauseTimestamp, w.createdTimestamp, w.user, w.group, w.timeUnitStr, w.timeOut from BundleJobBean w where (w.appName LIKE :text1 OR w.user LIKE :text2 OR w.id = :text3)Select w.id, w.appName, w.appPath, w.conf, w.statusStr, w.kickoffTimestamp, w.startTimestamp, w.endTimestamp, w.pauseTimestamp, w.createdTimestamp, w.user, w.group, w.timeUnitStr, w.timeOut from BundleJobBean w where w.statusStr IN (:status0) order by w.createdTimestamp desc" . It has generated the two select query for status and text.
        Hide
        jaydeepvishwakarma Jaydeep Vishwakarma added a comment -

        Abhishek Bafna, I did not mentioned isEnabled is not required. The condition statement is useless.

        if(false) {
        true
        }
        vs
        true
        

        Why do you need to check boolean when you any how going to make it true.

        Show
        jaydeepvishwakarma Jaydeep Vishwakarma added a comment - Abhishek Bafna , I did not mentioned isEnabled is not required. The condition statement is useless. if ( false ) { true } vs true Why do you need to check boolean when you any how going to make it true.
        Hide
        abhishekbafna Abhishek Bafna added a comment -

        absolutely correct.

        Show
        abhishekbafna Abhishek Bafna added a comment - absolutely correct.
        Hide
        pbacsko Peter Bacsko added a comment -

        True, this can be simplified - I just copy-pasted the already existing if-branches without too much thinking

        Show
        pbacsko Peter Bacsko added a comment - True, this can be simplified - I just copy-pasted the already existing if-branches without too much thinking
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA OOZIE-2225

        Cleaning local git workspace

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        +1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 132
        . +1 the patch does adds/modifies 3 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        -1 FindBugs diff JAR has a weird MD5 sum, rejecting.
        +1 BACKWARDS_COMPATIBILITY
        . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
        . +1 the patch does not modify JPA files
        -1 TESTS
        . Tests run: 1831
        . Tests failed: 1
        . Tests errors: 4

        . The patch failed the following testcases:

        . testGetBundleJobs(org.apache.oozie.TestV1JobsServletBundleEngine)

        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/oozie-trunk-precommit-build/3448/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2225 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings -1 FindBugs diff JAR has a weird MD5 sum, rejecting. +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 1831 . Tests failed: 1 . Tests errors: 4 . The patch failed the following testcases: . testGetBundleJobs(org.apache.oozie.TestV1JobsServletBundleEngine) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/3448/
        Hide
        pbacsko Peter Bacsko added a comment -

        Test failures are real... I'm going to fix it.

        Show
        pbacsko Peter Bacsko added a comment - Test failures are real... I'm going to fix it.
        Hide
        rohini Rohini Palaniswamy added a comment -

        Robert K. is out of office currently.

        Was out of office as well. Purshotam Shah is out till end of November.

        Test failures are real... I'm going to fix it.

        Will take a look once the test failures are fixed.

        Show
        rohini Rohini Palaniswamy added a comment - Robert K. is out of office currently. Was out of office as well. Purshotam Shah is out till end of November. Test failures are real... I'm going to fix it. Will take a look once the test failures are fixed.
        Hide
        hadoopqa Hadoop QA added a comment -

        Testing JIRA OOZIE-2225

        Cleaning local git workspace

        ----------------------------

        +1 PATCH_APPLIES
        +1 CLEAN
        +1 RAW_PATCH_ANALYSIS
        . +1 the patch does not introduce any @author tags
        . +1 the patch does not introduce any tabs
        . +1 the patch does not introduce any trailing spaces
        . +1 the patch does not introduce any line longer than 132
        . +1 the patch does adds/modifies 3 testcase(s)
        +1 RAT
        . +1 the patch does not seem to introduce new RAT warnings
        +1 JAVADOC
        . +1 the patch does not seem to introduce new Javadoc warnings
        +1 COMPILE
        . +1 HEAD compiles
        . +1 patch compiles
        . +1 the patch does not seem to introduce new javac warnings
        -1 FindBugs diff JAR has a weird MD5 sum, rejecting.
        +1 BACKWARDS_COMPATIBILITY
        . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
        . +1 the patch does not modify JPA files
        +1 TESTS
        . Tests run: 1831
        +1 DISTRO
        . +1 distro tarball builds with the patch

        ----------------------------
        -1 Overall result, please check the reported -1(s)

        The full output of the test-patch run is available at

        . https://builds.apache.org/job/oozie-trunk-precommit-build/3449/

        Show
        hadoopqa Hadoop QA added a comment - Testing JIRA OOZIE-2225 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN +1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . +1 the patch does adds/modifies 3 testcase(s) +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings -1 FindBugs diff JAR has a weird MD5 sum, rejecting. +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files +1 TESTS . Tests run: 1831 +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/3449/
        Hide
        rohini Rohini Palaniswamy added a comment - - edited

        +1. Committed OOZIE-2225-amend-004.patch to master. Thanks Peter Bacsko for fixing this.

        Thought we got rid of trunk version. Any idea why it was added back?

        Show
        rohini Rohini Palaniswamy added a comment - - edited +1. Committed OOZIE-2225 -amend-004.patch to master. Thanks Peter Bacsko for fixing this. Thought we got rid of trunk version. Any idea why it was added back?

          People

          • Assignee:
            sai-krish Sai Chirravuri
            Reporter:
            sai-krish Sai Chirravuri
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development