Oozie
  1. Oozie
  2. OOZIE-1414

Configuring Oozie for HTTPS still allows HTTP connections to all resources

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.0
    • Component/s: security
    • Labels:
      None

      Description

      When you run oozie-setup.sh prepare-war -secure it is supposed to replace server.xml with ssl-server.xml (in the oozie-server/conf/ dir) and web.xml with ssl-web.xml (in the WAR file).

      OOZIE-670 changed oozie-setup.sh to prepare the war file without calling addtowar.sh. However, the code added by OOZIE-1233 and OOZIE-1268 still delegates replacing web.xml with ssl-web.xml to addtowar.sh, which oozie-setup.sh no longer calls.

      Therefore, when you try to configure Oozie for HTTPS, it will use the original web.xml file; which means that all resources are accessible from both HTTPS and HTTP.

      This isn't an issue in Oozie 3.3.2 because it didn't include OOZIE-670, so addtowar.sh was still called.

      1. OOZIE-1414.patch
        1 kB
        Robert Kanter

        Issue Links

          Activity

          Hide
          Robert Kanter added a comment -

          The patch updates oozie-setup.sh to actually replace web.xml with ssl-web.xml. I also added in some better error checking on those files.

          No tests because its a script-only change, but I manually verified that it works properly.

          Show
          Robert Kanter added a comment - The patch updates oozie-setup.sh to actually replace web.xml with ssl-web.xml. I also added in some better error checking on those files. No tests because its a script-only change, but I manually verified that it works properly.
          Hide
          Hadoop QA added a comment -

          Testing JIRA OOZIE-1414

          Cleaning local svn workspace

          ----------------------------

          +1 PATCH_APPLIES
          +1 CLEAN
          -1 RAW_PATCH_ANALYSIS
          . +1 the patch does not introduce any @author tags
          . +1 the patch does not introduce any tabs
          . +1 the patch does not introduce any trailing spaces
          . +1 the patch does not introduce any line longer than 132
          . -1 the patch does not add/modify any testcase
          +1 RAT
          . +1 the patch does not seem to introduce new RAT warnings
          +1 JAVADOC
          . +1 the patch does not seem to introduce new Javadoc warnings
          +1 COMPILE
          . +1 HEAD compiles
          . +1 patch compiles
          . +1 the patch does not seem to introduce new javac warnings
          +1 BACKWARDS_COMPATIBILITY
          . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
          . +1 the patch does not modify JPA files
          -1 TESTS
          . Tests run: 1247
          . Tests failed: 1
          . Tests errors: 2

          . The patch failed the following testcases:

          . testEvictionOnTimeToIdle(org.apache.oozie.service.TestPartitionDependencyManagerEhcache)

          +1 DISTRO
          . +1 distro tarball builds with the patch

          ----------------------------
          -1 Overall result, please check the reported -1(s)

          The full output of the test-patch run is available at

          . https://builds.apache.org/job/oozie-trunk-precommit-build/586/

          Show
          Hadoop QA added a comment - Testing JIRA OOZIE-1414 Cleaning local svn workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS . +1 the patch does not introduce any @author tags . +1 the patch does not introduce any tabs . +1 the patch does not introduce any trailing spaces . +1 the patch does not introduce any line longer than 132 . -1 the patch does not add/modify any testcase +1 RAT . +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC . +1 the patch does not seem to introduce new Javadoc warnings +1 COMPILE . +1 HEAD compiles . +1 patch compiles . +1 the patch does not seem to introduce new javac warnings +1 BACKWARDS_COMPATIBILITY . +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . +1 the patch does not modify JPA files -1 TESTS . Tests run: 1247 . Tests failed: 1 . Tests errors: 2 . The patch failed the following testcases: . testEvictionOnTimeToIdle(org.apache.oozie.service.TestPartitionDependencyManagerEhcache) +1 DISTRO . +1 distro tarball builds with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/586/
          Hide
          Robert Kanter added a comment -

          No tests because its a script change.
          Test failures are unrelated.

          Show
          Robert Kanter added a comment - No tests because its a script change. Test failures are unrelated.
          Hide
          Alejandro Abdelnur added a comment -

          +1, LGTM

          Show
          Alejandro Abdelnur added a comment - +1, LGTM
          Hide
          Robert Kanter added a comment -

          Committed to trunk!

          Show
          Robert Kanter added a comment - Committed to trunk!

            People

            • Assignee:
              Robert Kanter
              Reporter:
              Robert Kanter
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development