[OODT-731] Fix File Manager Unit Tests - 'catalog' Package

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.7
• Fix Version/s: 0.7
• Component/s: file manager
• Labels: patch test
• Skill Level: Don't Know (Unsure) - The default level
• Assignee: Ross Laidlaw
• Reporter: Ross Laidlaw
• Created: 05/Aug/14 17:30
• Updated: 05/Aug/14 20:48
• Resolved: 05/Aug/14 20:48

Description

This step fixes unit tests for the file manager's 'catalog' package. It makes similar changes to those made in OODT-722, OODT-723 and OODT-729. Four test classes are affected: TestDataSourceCatalog, TestLuceneCatalog, TestMappedDataSourceCatalog and TestOrderedDataSourceCatalog.

In each case, I've replaced hard-coded paths to test resources with paths from URLs via the 'getResource()' method. I've also used java.util.Properties objects to set System properties and then restore initial settings after each test is run.

Running the following command from the top-level (trunk) directory for each test class:

mvn clean -Dtest=<test class name> -DfailIfNoTests=false test -pl filemgr -am

The results obtained were as follows:

Before applying the patch:

TestDataSourceCatalog Results :
  Tests run: 7, Failures: 7, Errors: 0, Skipped: 0

TestLuceneCatalog Results:
  Tests run: 12, Failures: 12, Errors: 0, Skipped: 0

TestMappedDataSourceCatalog Results :
  Tests run: 7, Failures: 7, Errors: 0, Skipped: 0

TestOrderedDataSourceCatalog Results :
  Tests run: 8, Failures: 8, Errors: 0, Skipped: 0

After applying the patch:

TestDataSourceCatalog Results :
  Tests run: 7, Failures: 0, Errors: 0, Skipped: 0

TestLuceneCatalog Results:
  Tests run: 12, Failures: 0, Errors: 0, Skipped: 0

TestMappedDataSourceCatalog Results :
  Tests run: 7, Failures: 0, Errors: 0, Skipped: 0

TestOrderedDataSourceCatalog Results :
  Tests run: 8, Failures: 0, Errors: 0, Skipped: 0