[OODT-571] Assignments in the setWorkflowInst and setWaitforConditionSatisfy methods need 'this' keyword

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.5
• Fix Version/s: 0.6
• Component/s: workflow manager
• Assignee: Ross Laidlaw
• Reporter: Ross Laidlaw
• Created: 07/Mar/13 23:04
• Updated: 08/Jun/13 00:10
• Resolved: 08/Jun/13 00:10

Description

I found minor bugs in two setter methods in the org.apache.oodt.cas.workflow.engine.IterativeWorkflowProcessorThread class:

IterativeWorkflowProcessorThread.java

public void setWorkflowInst(WorkflowInstance workflowInst)
{
  workflowInst = workflowInst;
}

public void setWaitforConditionSatisfy(long waitforConditionSatisfy)
{
  waitForConditionSatisfy = waitforConditionSatisfy;
}

They should be changed to the following so that values from the parameters are assigned to member variables:

IterativeWorkflowProcessorThread.java

public void setWorkflowInst(WorkflowInstance workflowInst)
{
  this.workflowInst = workflowInst;
}

public void setWaitforConditionSatisfy(long waitforConditionSatisfy)
{
  this.waitForConditionSatisfy = waitforConditionSatisfy;
}

I've attached a patch for reference. Although this should be a trivial change I wanted to post this issue and patch to make sure that the change would be ok.