OODT
  1. OODT
  2. OODT-440

Replace legacy getMetadata("UUID") calls with getMetadata("CAS." + CoreMetKeys.PRODUCT_ID)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.4
    • Fix Version/s: 0.4
    • Component/s: file manager
    • Labels:

      Description

      There are some legacy calls to retrieve a products UUID. This should instead retrieve the products ProductId.

      These calls are found in org.pache.oodt.cas.filemgr.tools.SolrIndexer

      1. OODT-440.patch.txt
        1 kB
        Thomas Bennett

        Activity

        Hide
        Thomas Bennett added a comment -

        Patch with fix.

        Show
        Thomas Bennett added a comment - Patch with fix.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4709/
        -----------------------------------------------------------

        Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.

        Summary
        -------

        String search and replace getMetadata("UUID with getMetadata("CAS.ProductId

        This addresses bug OODT-440.
        https://issues.apache.org/jira/browse/OODT-440

        Diffs


        trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745

        Diff: https://reviews.apache.org/r/4709/diff

        Testing
        -------

        Unit test pass
        Works on my installed OODT ditribution

        Thanks,

        Thomas

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/ ----------------------------------------------------------- Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John. Summary ------- String search and replace getMetadata("UUID with getMetadata("CAS.ProductId This addresses bug OODT-440 . https://issues.apache.org/jira/browse/OODT-440 Diffs trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745 Diff: https://reviews.apache.org/r/4709/diff Testing ------- Unit test pass Works on my installed OODT ditribution Thanks, Thomas
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4709/#review6881
        -----------------------------------------------------------

        Ship it!

        LGTM!

        • Chris

        On 2012-04-12 13:33:57, Thomas Bennett wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4709/

        -----------------------------------------------------------

        (Updated 2012-04-12 13:33:57)

        Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.

        Summary

        -------

        String search and replace getMetadata("UUID with getMetadata("CAS.ProductId

        This addresses bug OODT-440.

        https://issues.apache.org/jira/browse/OODT-440

        Diffs

        -----

        trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745

        Diff: https://reviews.apache.org/r/4709/diff

        Testing

        -------

        Unit test pass

        Works on my installed OODT ditribution

        Thanks,

        Thomas

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/#review6881 ----------------------------------------------------------- Ship it! LGTM! Chris On 2012-04-12 13:33:57, Thomas Bennett wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/ ----------------------------------------------------------- (Updated 2012-04-12 13:33:57) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John. Summary ------- String search and replace getMetadata("UUID with getMetadata("CAS.ProductId This addresses bug OODT-440 . https://issues.apache.org/jira/browse/OODT-440 Diffs ----- trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745 Diff: https://reviews.apache.org/r/4709/diff Testing ------- Unit test pass Works on my installed OODT ditribution Thanks, Thomas
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4709/#review6891
        -----------------------------------------------------------

        trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java
        <https://reviews.apache.org/r/4709/#comment15335>

        How about using CoreMetKeys.PRODUCT_ID ?

        • Ricky

        On 2012-04-12 13:33:57, Thomas Bennett wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4709/

        -----------------------------------------------------------

        (Updated 2012-04-12 13:33:57)

        Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.

        Summary

        -------

        String search and replace getMetadata("UUID with getMetadata("CAS.ProductId

        This addresses bug OODT-440.

        https://issues.apache.org/jira/browse/OODT-440

        Diffs

        -----

        trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745

        Diff: https://reviews.apache.org/r/4709/diff

        Testing

        -------

        Unit test pass

        Works on my installed OODT ditribution

        Thanks,

        Thomas

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/#review6891 ----------------------------------------------------------- trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java < https://reviews.apache.org/r/4709/#comment15335 > How about using CoreMetKeys.PRODUCT_ID ? Ricky On 2012-04-12 13:33:57, Thomas Bennett wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/ ----------------------------------------------------------- (Updated 2012-04-12 13:33:57) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John. Summary ------- String search and replace getMetadata("UUID with getMetadata("CAS.ProductId This addresses bug OODT-440 . https://issues.apache.org/jira/browse/OODT-440 Diffs ----- trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745 Diff: https://reviews.apache.org/r/4709/diff Testing ------- Unit test pass Works on my installed OODT ditribution Thanks, Thomas
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4709/#review6892
        -----------------------------------------------------------

        trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java
        <https://reviews.apache.org/r/4709/#comment15336>

        i think paul mentioned this "uuid" too

        • Ricky

        On 2012-04-12 13:33:57, Thomas Bennett wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4709/

        -----------------------------------------------------------

        (Updated 2012-04-12 13:33:57)

        Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.

        Summary

        -------

        String search and replace getMetadata("UUID with getMetadata("CAS.ProductId

        This addresses bug OODT-440.

        https://issues.apache.org/jira/browse/OODT-440

        Diffs

        -----

        trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745

        Diff: https://reviews.apache.org/r/4709/diff

        Testing

        -------

        Unit test pass

        Works on my installed OODT ditribution

        Thanks,

        Thomas

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/#review6892 ----------------------------------------------------------- trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java < https://reviews.apache.org/r/4709/#comment15336 > i think paul mentioned this "uuid" too Ricky On 2012-04-12 13:33:57, Thomas Bennett wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/ ----------------------------------------------------------- (Updated 2012-04-12 13:33:57) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John. Summary ------- String search and replace getMetadata("UUID with getMetadata("CAS.ProductId This addresses bug OODT-440 . https://issues.apache.org/jira/browse/OODT-440 Diffs ----- trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745 Diff: https://reviews.apache.org/r/4709/diff Testing ------- Unit test pass Works on my installed OODT ditribution Thanks, Thomas
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4709/#review6897
        -----------------------------------------------------------

        Ship it!

        Other than what the other 2 commenters already mentioned LGTM.

        • Paul

        On 2012-04-12 13:33:57, Thomas Bennett wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4709/

        -----------------------------------------------------------

        (Updated 2012-04-12 13:33:57)

        Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.

        Summary

        -------

        String search and replace getMetadata("UUID with getMetadata("CAS.ProductId

        This addresses bug OODT-440.

        https://issues.apache.org/jira/browse/OODT-440

        Diffs

        -----

        trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745

        Diff: https://reviews.apache.org/r/4709/diff

        Testing

        -------

        Unit test pass

        Works on my installed OODT ditribution

        Thanks,

        Thomas

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/#review6897 ----------------------------------------------------------- Ship it! Other than what the other 2 commenters already mentioned LGTM. Paul On 2012-04-12 13:33:57, Thomas Bennett wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/ ----------------------------------------------------------- (Updated 2012-04-12 13:33:57) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John. Summary ------- String search and replace getMetadata("UUID with getMetadata("CAS.ProductId This addresses bug OODT-440 . https://issues.apache.org/jira/browse/OODT-440 Diffs ----- trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745 Diff: https://reviews.apache.org/r/4709/diff Testing ------- Unit test pass Works on my installed OODT ditribution Thanks, Thomas
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4709/#review6909
        -----------------------------------------------------------

        Ship it!

        • Chris

        On 2012-04-12 13:33:57, Thomas Bennett wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4709/

        -----------------------------------------------------------

        (Updated 2012-04-12 13:33:57)

        Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.

        Summary

        -------

        String search and replace getMetadata("UUID with getMetadata("CAS.ProductId

        This addresses bug OODT-440.

        https://issues.apache.org/jira/browse/OODT-440

        Diffs

        -----

        trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745

        Diff: https://reviews.apache.org/r/4709/diff

        Testing

        -------

        Unit test pass

        Works on my installed OODT ditribution

        Thanks,

        Thomas

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/#review6909 ----------------------------------------------------------- Ship it! Chris On 2012-04-12 13:33:57, Thomas Bennett wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/ ----------------------------------------------------------- (Updated 2012-04-12 13:33:57) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John. Summary ------- String search and replace getMetadata("UUID with getMetadata("CAS.ProductId This addresses bug OODT-440 . https://issues.apache.org/jira/browse/OODT-440 Diffs ----- trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745 Diff: https://reviews.apache.org/r/4709/diff Testing ------- Unit test pass Works on my installed OODT ditribution Thanks, Thomas
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4709/#review6910
        -----------------------------------------------------------

        Ship it!

        Nice catch! Looks good. Note the "uuid" too.

        • Sheryl

        On 2012-04-12 13:33:57, Thomas Bennett wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4709/

        -----------------------------------------------------------

        (Updated 2012-04-12 13:33:57)

        Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.

        Summary

        -------

        String search and replace getMetadata("UUID with getMetadata("CAS.ProductId

        This addresses bug OODT-440.

        https://issues.apache.org/jira/browse/OODT-440

        Diffs

        -----

        trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745

        Diff: https://reviews.apache.org/r/4709/diff

        Testing

        -------

        Unit test pass

        Works on my installed OODT ditribution

        Thanks,

        Thomas

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/#review6910 ----------------------------------------------------------- Ship it! Nice catch! Looks good. Note the "uuid" too. Sheryl On 2012-04-12 13:33:57, Thomas Bennett wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/ ----------------------------------------------------------- (Updated 2012-04-12 13:33:57) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John. Summary ------- String search and replace getMetadata("UUID with getMetadata("CAS.ProductId This addresses bug OODT-440 . https://issues.apache.org/jira/browse/OODT-440 Diffs ----- trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745 Diff: https://reviews.apache.org/r/4709/diff Testing ------- Unit test pass Works on my installed OODT ditribution Thanks, Thomas
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4709/
        -----------------------------------------------------------

        (Updated 2012-04-17 14:36:54.936567)

        Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.

        Changes
        -------

        Added all suggested changes. Thanks for the extra uuid catch.

        Summary
        -------

        String search and replace getMetadata("UUID with getMetadata("CAS.ProductId

        This addresses bug OODT-440.
        https://issues.apache.org/jira/browse/OODT-440

        Diffs (updated)


        trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745

        Diff: https://reviews.apache.org/r/4709/diff

        Testing
        -------

        Unit test pass
        Works on my installed OODT ditribution

        Thanks,

        Thomas

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/ ----------------------------------------------------------- (Updated 2012-04-17 14:36:54.936567) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John. Changes ------- Added all suggested changes. Thanks for the extra uuid catch. Summary ------- String search and replace getMetadata("UUID with getMetadata("CAS.ProductId This addresses bug OODT-440 . https://issues.apache.org/jira/browse/OODT-440 Diffs (updated) trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745 Diff: https://reviews.apache.org/r/4709/diff Testing ------- Unit test pass Works on my installed OODT ditribution Thanks, Thomas
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4709/#review6997
        -----------------------------------------------------------

        Ship it!

        LGTM.

        • Chris

        On 2012-04-17 14:36:54, Thomas Bennett wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4709/

        -----------------------------------------------------------

        (Updated 2012-04-17 14:36:54)

        Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.

        Summary

        -------

        String search and replace getMetadata("UUID with getMetadata("CAS.ProductId

        This addresses bug OODT-440.

        https://issues.apache.org/jira/browse/OODT-440

        Diffs

        -----

        trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745

        Diff: https://reviews.apache.org/r/4709/diff

        Testing

        -------

        Unit test pass

        Works on my installed OODT ditribution

        Thanks,

        Thomas

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/#review6997 ----------------------------------------------------------- Ship it! LGTM. Chris On 2012-04-17 14:36:54, Thomas Bennett wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/ ----------------------------------------------------------- (Updated 2012-04-17 14:36:54) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John. Summary ------- String search and replace getMetadata("UUID with getMetadata("CAS.ProductId This addresses bug OODT-440 . https://issues.apache.org/jira/browse/OODT-440 Diffs ----- trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745 Diff: https://reviews.apache.org/r/4709/diff Testing ------- Unit test pass Works on my installed OODT ditribution Thanks, Thomas
        Hide
        Thomas Bennett added a comment -

        Code updated test and committed.

        Show
        Thomas Bennett added a comment - Code updated test and committed.

          People

          • Assignee:
            Thomas Bennett
            Reporter:
            Thomas Bennett
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development