[OLINGO-999] Cannot add more than one request into ChangSet - thread halts in infinite loop

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Resolved
• Affects Version/s: (Java) V4 4.2.0
• Component/s: odata4-client, odata4-commons
• Labels: batch changeset thread-safety
• Assignee: Unassigned
• Reporter: Punith DG
• Created: 10/Aug/16 13:42
• Updated: 27/Nov/19 08:00
• Resolved: 09/Sep/16 12:07

Description

I am not able to add more than one request to a batch ChangeSet as the BatchManager has PipedOutputStream Writer that's causing thread to get into infinite loop.
Check the below sample code in which I'm trying to add requests.

for loop{
ODataBatchRequest batchRequest = client.getBatchRequestFactory().getBatchRequest("serviceRootURI");
BatchManager payloadManager = batchRequest.payloadManager();
ODataChangeset changeset = payloadManager.addChangeset();
ODataEntityCreateRequest<ClientEntity> createRequest = client.getCUDRequestFactory()
.getEntityCreateRequest(new URI("serviceRoot"), clientEntity);
createRequest.setFormat(ContentType.JSON);

changeset.addRequest(createRequest); // here the thread waits in infinite loop due to piped streams sync problem.
}
The problem is observed in line "request.batch(req, String.valueOf(contentId));" in addRequest() method of ODataChangesetImpl class.
It seems a known issue in Java - http://stackoverflow.com/questions/9171632/piped-input-stream-is-getting-locked

Issue Links

• links to: GitHub Pull Request #29
• links to: PipedInputStream read() gets in infinite loop