[OLINGO-998] Accept header parsing should be more tolerant of malformed jdk accept header

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Sahir Hoda
• Created: 09/Aug/16 19:47
• Updated: 09/Aug/16 19:48

Description

The jdk HttpURLConnection sets the following accept header if one is not specified:

Accept: text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2

Requests with this header to an olingo 4 endpoint result in a 500 response and the following stack trace on the server:

java.lang.IllegalArgumentException: Not exactly one '/' in format '*; q=.2', or it is at the beginning or at the end.
        at org.apache.olingo.commons.api.format.AcceptType.parse(AcceptType.java:116)
        at org.apache.olingo.commons.api.format.AcceptType.<init>(AcceptType.java:78)
        at org.apache.olingo.commons.api.format.AcceptType.create(AcceptType.java:134)
        at org.apache.olingo.server.core.ContentNegotiator.doContentNegotiation(ContentNegotiator.java:96)
        at org.apache.olingo.server.core.ODataHandler.handleException(ODataHandler.java:224)
        at org.apache.olingo.server.core.ODataHttpHandlerImpl.handleException(ODataHttpHandlerImpl.java:90)
        at org.apache.olingo.server.core.ODataHttpHandlerImpl.process(ODataHttpHandlerImpl.java:69)
        at org.apache.olingo.server.sample.CarsServlet.service(CarsServlet.java:61)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:230)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165)
        at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165)
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:108)
        at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:522)
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79)
        at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:620)
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:349)
        at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:1110)
        at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
        at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:785)
        at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1425)
        at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
        at java.lang.Thread.run(Thread.java:745)

Easily reproduced using the Demo servelet running a tomcat on localhost:8080, with the following code:

        URL url = new URL("http://localhost:8080/odata-server-sample-4.0.0-beta-02/cars.svc/$metadata");
        HttpURLConnection conn = (HttpURLConnection) url.openConnection();

        try (BufferedReader in = new BufferedReader(new InputStreamReader(conn.getInputStream()));) {
            String line = null;
            while ((line = in.readLine()) != null) {
                System.out.println(line);
            }
        }