[OLINGO-501] ODataJsonSerializer fails to write Collections of Complex Properties

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: (Java) V4 4.0.0-beta-01
• Fix Version/s: (Java) V4 4.0.0-beta-02
• Component/s: odata4-server
• Labels: easyfix
• Assignee: mibo
• Reporter: Michael Burwig
• Created: 01/Dec/14 12:20
• Updated: 09/Dec/14 14:39
• Resolved: 09/Dec/14 14:39

Description

Affected Method:
org.apache.olingo.server.core.serializer.json.ODataJsonSerializer.writeComplexCollection(type, property, ...)

The method writeComplexCollection iterates over the properties of a collection of properties and calls writeComplexValue(...).

ODataJsonSerializer.java

...
for (Object value : property.asCollection()) {
  switch (property.getValueType()) {
  case COLLECTION_LINKED_COMPLEX:
    writeComplexValue(type, ((LinkedComplexValue) value).getValue(), selectedPaths, json);
    break;
  case COLLECTION_COMPLEX:
    writeComplexValue(type, property.asComplex(), selectedPaths, json);
    break;
...

The COLLECTION_COMPLEX case seems broken and should rather be something like:

ODataJsonSerializer.java

...
  case COLLECTION_COMPLEX:
    writeComplexValue(type, ((Property) value).asComplex(), selectedPaths, json);
    break;
...

Issue Links

• Is contained by: OLINGO-499 AbstractValuable.isComplex