[OLINGO-436] Code duplication batch request

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: V2 2.0.1
• Fix Version/s: V2 2.0.1
• Component/s: odata2-core
• Labels: batch parser
• Assignee: Christian Amend
• Reporter: Christian Holzer
• Created: 18/Sep/14 10:56
• Updated: 06/Nov/14 16:26
• Resolved: 10/Oct/14 07:32

Description

Within the batch parser exists some duplicated code. The duplication is based on the same structure of the batch request and the batch response. So I would like to suggest a refactoring to create a common basis for batch requests and responses, also.

In my opinion the parsing could be split up in two parts. The common part could parse the syntactic structure of a batch message. Based on the type of message, a suitable semantic parser will be chosen. The semantic parser validates the input and creates the necessary ODataRequests or ODataSingleResponses.

I attached a patch.