Uploaded image for project: 'Commons OGNL (Dormant)'
  1. Commons OGNL (Dormant)
  2. OGNL-53

OR fails with boolean expression as first condition

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.7
    • 2.7
    • ExpressionCompiler
    • None
    • Tapestry 4.1.2 snapshot from 4-20, OGNL 2.7 snapshot from 4-20, WinXP, Firefox 2

    Description

      Failsafe catches this and the page renders fine.

      .html:

      <span jwcid="@Insert" value="ognl:(1 > 0 && true) || 2 > 0" />

      Error displayed in the console:

      org.apache.hivemind.ApplicationRuntimeException: Unable to add method java.lang.Object get(ognl.OgnlContext, java.lang.Object) to class ognl.ASTOr20962278Accessor: [source error] boolean expr is required

      at org.apache.tapestry.enhance.ClassFabImpl.addMethod(ClassFabImpl.java:278)

      at org.apache.tapestry.services.impl.HiveMindExpressionCompiler.compileExpression(HiveMindExpressionCompiler.java:161)

      at ognl.OgnlRuntime.compileExpression(OgnlRuntime.java:387)

      at ognl.Ognl.compileExpression(Ognl.java:123)

      at org.apache.tapestry.services.impl.ExpressionCacheImpl.parse(ExpressionCacheImpl.java:129)

      at org.apache.tapestry.services.impl.ExpressionCacheImpl.getCompiledExpression(ExpressionCacheImpl.java:91)

      at $ExpressionCache_11224767822.getCompiledExpression($ExpressionCache_11224767822.java)

      at org.apache.tapestry.binding.ExpressionBinding.resolveExpression(ExpressionBinding.java:120)

      at org.apache.tapestry.binding.ExpressionBinding.getObject(ExpressionBinding.java:111)

      at org.apache.tapestry.binding.AbstractBinding.getObject(AbstractBinding.java:84)

      at $Insert_1029.getValue($Insert_1029.java)

      at org.apache.tapestry.components.Insert.renderComponent(Insert.java:48)

      at org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:712)

      at org.apache.tapestry.services.impl.DefaultResponseBuilder.render(DefaultResponseBuilder.java:184)

      at org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:525)

      at org.apache.tapestry.components.RenderBody.renderComponent(RenderBody.java:41)

      at org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:712)

      at org.apache.tapestry.services.impl.DefaultResponseBuilder.render(DefaultResponseBuilder.java:184)

      at org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:525)

      at org.apache.tapestry.components.RenderBody.renderComponent(RenderBody.java:41)

      at org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:712)

      at org.apache.tapestry.services.impl.DefaultResponseBuilder.render(DefaultResponseBuilder.java:184)

      at org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:525)

      at org.apache.tapestry.components.RenderBody.renderComponent(RenderBody.java:41)

      at org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:712)

      at org.apache.tapestry.services.impl.DefaultResponseBuilder.render(DefaultResponseBuilder.java:184)

      at org.apache.tapestry.BaseComponent.renderComponent(BaseComponent.java:92)

      at collective.ui.components.CollectiveComponent.renderComponent(CollectiveComponent.java:70)

      at org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:712)

      at org.apache.tapestry.services.impl.DefaultResponseBuilder.render(DefaultResponseBuilder.java:184)

      at org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:525)

      at org.apache.tapestry.components.Any.renderComponent(Any.java:53)

      at org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:712)

      at org.apache.tapestry.services.impl.DefaultResponseBuilder.render(DefaultResponseBuilder.java:184)

      at org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:525)

      at org.apache.tapestry.html.Body.renderComponent(Body.java:38)

      at org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:712)

      at org.apache.tapestry.services.impl.DefaultResponseBuilder.render(DefaultResponseBuilder.java:184)

      at org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:525)

      at org.apache.tapestry.html.Shell.renderComponent(Shell.java:64)

      at org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:712)

      at org.apache.tapestry.services.impl.DefaultResponseBuilder.render(DefaultResponseBuilder.java:184)

      at org.apache.tapestry.BaseComponent.renderComponent(BaseComponent.java:92)

      at collective.ui.components.CollectiveComponent.renderComponent(CollectiveComponent.java:70)

      at org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:712)

      at org.apache.tapestry.services.impl.DefaultResponseBuilder.render(DefaultResponseBuilder.java:184)

      at org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:525)

      at org.apache.tapestry.components.ElseBean.renderComponent(ElseBean.java:47)

      at org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:712)

      at org.apache.tapestry.services.impl.DefaultResponseBuilder.render(DefaultResponseBuilder.java:184)

      at org.apache.tapestry.BaseComponent.renderComponent(BaseComponent.java:92)

      at collective.ui.components.CollectiveComponent.renderComponent(CollectiveComponent.java:70)

      at org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:712)

      at org.apache.tapestry.services.impl.DefaultResponseBuilder.render(DefaultResponseBuilder.java:184)

      at org.apache.tapestry.BaseComponent.renderComponent(BaseComponent.java:92)

      at org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:712)

      at org.apache.tapestry.services.impl.DefaultResponseBuilder.render(DefaultResponseBuilder.java:182)

      at org.apache.tapestry.AbstractPage.renderPage(AbstractPage.java:237)

      at org.apache.tapestry.engine.RequestCycle.renderPage(RequestCycle.java:397)

      at org.apache.tapestry.services.impl.DefaultResponseBuilder.renderResponse(DefaultResponseBuilder.java:158)

      at org.apache.tapestry.services.impl.ResponseRendererImpl.renderResponse(ResponseRendererImpl.java:33)

      at $ResponseRenderer_112247676b4.renderResponse($ResponseRenderer_112247676b4.java)

      at org.apache.tapestry.engine.PageService.service(PageService.java:68)

      at $IEngineService_11224767747.service($IEngineService_11224767747.java)

      at org.apache.tapestry.services.impl.EngineServiceOuterProxy.service(EngineServiceOuterProxy.java:72)

      at org.apache.tapestry.engine.AbstractEngine.service(AbstractEngine.java:246)

      at org.apache.tapestry.services.impl.InvokeEngineTerminator.service(InvokeEngineTerminator.java:54)

      at $WebRequestServicer_11224767724.service($WebRequestServicer_11224767724.java)

      at org.apache.tapestry.services.impl.DisableCachingFilter.service(DisableCachingFilter.java:54)

      at $WebRequestServicerFilter_11224767726.service($WebRequestServicerFilter_11224767726.java)

      at $WebRequestServicer_11224767728.service($WebRequestServicer_11224767728.java)

      at $WebRequestServicer_11224767720.service($WebRequestServicer_11224767720.java)

      at org.apache.tapestry.services.impl.WebRequestServicerPipelineBridge.service(WebRequestServicerPipelineBridge.java:61)

      at $ServletRequestServicer_11224767702.service($ServletRequestServicer_11224767702.java)

      at org.apache.tapestry.request.DecodedRequestInjector.service(DecodedRequestInjector.java:55)

      at $ServletRequestServicerFilter_112247676fe.service($ServletRequestServicerFilter_112247676fe.java)

      at $ServletRequestServicer_11224767704.service($ServletRequestServicer_11224767704.java)

      at collective.ui.custom.HibernateFilter.service(HibernateFilter.java:37)

      at $ServletRequestServicerFilter_112247676fc.service($ServletRequestServicerFilter_112247676fc.java)

      at $ServletRequestServicer_11224767704.service($ServletRequestServicer_11224767704.java)

      at collective.ui.custom.LuceneIndexFilter.service(LuceneIndexFilter.java:24)

      at $ServletRequestServicerFilter_112247676fa.service($ServletRequestServicerFilter_112247676fa.java)

      at $ServletRequestServicer_11224767704.service($ServletRequestServicer_11224767704.java)

      at org.apache.tapestry.multipart.MultipartDecoderFilter.service(MultipartDecoderFilter.java:52)

      at $ServletRequestServicerFilter_112247676f8.service($ServletRequestServicerFilter_112247676f8.java)

      at $ServletRequestServicer_11224767704.service($ServletRequestServicer_11224767704.java)

      at org.apache.tapestry.services.impl.SetupRequestEncoding.service(SetupRequestEncoding.java:53)

      at $ServletRequestServicerFilter_11224767700.service($ServletRequestServicerFilter_11224767700.java)

      at $ServletRequestServicer_11224767704.service($ServletRequestServicer_11224767704.java)

      at $ServletRequestServicer_112247676f1.service($ServletRequestServicer_112247676f1.java)

      at org.apache.tapestry.ApplicationServlet.doService(ApplicationServlet.java:123)

      at collective.ui.CollectiveApplicationServlet.doService(CollectiveApplicationServlet.java:71)

      at org.apache.tapestry.ApplicationServlet.doGet(ApplicationServlet.java:104)

      at javax.servlet.http.HttpServlet.service(HttpServlet.java:743)

      at javax.servlet.http.HttpServlet.service(HttpServlet.java:856)

      at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:427)

      at org.mortbay.jetty.servlet.WebApplicationHandler$CachedChain.doFilter(WebApplicationHandler.java:832)

      at collective.servlet.ResponseHeaderFilter.doFilter(ResponseHeaderFilter.java:32)

      at org.mortbay.jetty.servlet.WebApplicationHandler$CachedChain.doFilter(WebApplicationHandler.java:823)

      at org.mortbay.jetty.servlet.WebApplicationHandler.dispatch(WebApplicationHandler.java:473)

      at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:556)

      at org.mortbay.http.HttpContext.handle(HttpContext.java:1563)

      at org.mortbay.jetty.servlet.WebApplicationContext.handle(WebApplicationContext.java:623)

      at org.mortbay.http.HttpContext.handle(HttpContext.java:1515)

      at org.mortbay.http.HttpServer.service(HttpServer.java:956)

      at org.mortbay.http.HttpConnection.service(HttpConnection.java:814)

      at org.mortbay.http.HttpConnection.handleNext(HttpConnection.java:981)

      at org.mortbay.http.HttpConnection.handle(HttpConnection.java:831)

      at org.mortbay.http.SocketListener.handleConnection(SocketListener.java:244)

      at org.mortbay.util.ThreadedServer.handle(ThreadedServer.java:357)

      at org.mortbay.util.ThreadPool$PoolThread.run(ThreadPool.java:534)

      Caused by: javassist.CannotCompileException: [source error] boolean expr is required

      at javassist.CtBehavior.setBody(CtBehavior.java:347)

      at javassist.CtBehavior.setBody(CtBehavior.java:316)

      at org.apache.tapestry.enhance.ClassFabImpl.addMethod(ClassFabImpl.java:272)

      ... 110 more

      Caused by: compile error: boolean expr is required

      at javassist.compiler.CodeGen.booleanExpr(CodeGen.java:1115)

      at javassist.compiler.CodeGen.atCondExpr(CodeGen.java:904)

      at javassist.compiler.ast.CondExpr.accept(CondExpr.java:42)

      at javassist.compiler.CodeGen.atCondExpr(CodeGen.java:907)

      at javassist.compiler.ast.CondExpr.accept(CondExpr.java:42)

      at javassist.compiler.JvstCodeGen.atCastToWrapper(JvstCodeGen.java:201)

      at javassist.compiler.JvstCodeGen.atCastExpr(JvstCodeGen.java:171)

      at javassist.compiler.ast.CastExpr.accept(CastExpr.java:54)

      at javassist.compiler.CodeGen.compileExpr(CodeGen.java:223)

      at javassist.compiler.CodeGen.atReturnStmnt2(CodeGen.java:591)

      at javassist.compiler.JvstCodeGen.atReturnStmnt(JvstCodeGen.java:424)

      at javassist.compiler.CodeGen.atStmnt(CodeGen.java:356)

      at javassist.compiler.ast.Stmnt.accept(Stmnt.java:49)

      at javassist.compiler.CodeGen.atStmnt(CodeGen.java:344)

      at javassist.compiler.ast.Stmnt.accept(Stmnt.java:49)

      at javassist.compiler.CodeGen.atMethodBody(CodeGen.java:285)

      at javassist.compiler.Javac.compileBody(Javac.java:212)

      at javassist.CtBehavior.setBody(CtBehavior.java:341)

      ... 112 more

      Attachments

        Activity

          People

            jkuhnert Jesse Kuhnert
            dotteben Ben Dotte
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: