Uploaded image for project: 'Commons OGNL'
  1. Commons OGNL
  2. OGNL-224

Performance - Locking and performance problem with OgnlRuntime.findParameterTypes

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.0
    • 3.0
    • Core Runtime
    • Patch

    Description

      I am using struts2 and under heavy load (around 100 threads) many threads are in BLOCKED state because of OgnlRuntime.findParameterTypes(). The actions we use have a generic superclass like:
      public class PersonalCaptureAction extends DataCaptureAction<PersonalDTO>
      OGNL handles this very bad, it enters
      synchronized (_genericMethodParameterTypesCache)
      all the time, at every property access of the Action. A possible workaround is to introduce another layer of superclass that is not generic.

      I know that in current OGNL trunk (4.0-SNAPSHOT) caching has been rewritten, but Struts2 is using 3.0.5, and maybe it could be fixed as 3.0.6 in the git tree I found:
      https://github.com/jkuhnert/ognl

      I will attach a patch and a testcase.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            lukaszlenart Lukasz Lenart
            pelladi Pelladi Gabor
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment