[OGNL-214] [PATCH] Findbugs fixes

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0
• Assignee: Maurizio Cucchiara
• Reporter: Adrian Cumiskey
• Created: 03/Nov/11 06:40
• Updated: 27/Mar/13 12:37
• Resolved: 03/Nov/11 10:05

Description

ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() implementation to override PropertyDescriptor.
ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always of type String).
ASTMethod: Use StringBuilder instead of String concatenation with '+'.
DeclaredMethodCacheEntry: Modified equals() implementation to take account of super class fields.
OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet for better performance. Javadoc improvements.
ASTChain: Remove int boxing, lets rely on autoboxing.
ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary conditional checking.