Uploaded image for project: 'Commons OGNL'
  1. Commons OGNL
  2. OGNL-192

Remove dead and broken code from OgnlRuntime/SimpleNode

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0
    • Component/s: None
    • Labels:

      Description

      I noticed there are some apparently unnecessary methods in both SimpleNode and OgnlRuntime.

      I've created a patch which removes them, and the unit tests still run fine.

      One of the methods was clearly buggy and would cause ClassCastExceptions if used (it put an array into a cache which was used to also store Maps).

        Attachments

        1. Remove-dead-code.patch
          16 kB
          Daniel Pitts

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              danielpitts Daniel Pitts
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: