[OFBIZ-9964] UtilMisc.ensureLocale does not always return a valid Locale

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Release Branch 16.11, Trunk
• Fix Version/s: 16.11.04
• Component/s: framework
• Assignee: Michael Brohl
• Reporter: Michael Brohl
• Created: 04/Nov/17 09:58
• Updated: 04/Nov/17 19:48
• Resolved: 04/Nov/17 19:48

Description

The Javadoc promises that the function will always return a valid Locale, at least a default.
This does not work if a String is provided which cannot be parsed to a valid locale through the parseLocale function which can return null.

    public static Locale ensureLocale(Object localeObject) {
        if (localeObject instanceof String) {
            return parseLocale((String) localeObject);
        } else if (localeObject instanceof Locale) {
            return (Locale) localeObject;
        }
        return Locale.getDefault();
    }

I will provide a patch for it.