Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9836

General refactoring and code improvements

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: 17.12.01
    • Component/s: ALL COMPONENTS
    • Labels:
      None

      Description

      • Diamond Operators (removing unnecessary parameters)
      • unnecessary else (removing unnecessary else-phrase, e.g. when the if-phrase always ends in a return)
      • multi catches (using multi catches instead of multiple single ones, if possible)
      • enhance for-loops:
        for (int zahl : zahlen) {   System.out.print(zahl + " "); }
      • remove exceptions which aren't thrown (some methods claim to throw exceptions, which aren't actually thrown, they will be removed)
      • remove old commented unnecessary code
      • put {} around every if and else (this is to make the code more even, because some coders use it and some don't)

      there will be separate patches for each class of the package for easier reviewing and patching purposes

        Attachments

          Activity

            People

            • Assignee:
              mbrohl Michael Brohl
              Reporter:
              Dennis Balkir Dennis Balkir
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: