Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9836

General refactoring and code improvements

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: 17.12.01
    • Component/s: ALL COMPONENTS
    • Labels:
      None

      Description

      • Diamond Operators (removing unnecessary parameters)
      • unnecessary else (removing unnecessary else-phrase, e.g. when the if-phrase always ends in a return)
      • multi catches (using multi catches instead of multiple single ones, if possible)
      • enhance for-loops:
        for (int zahl : zahlen) {   System.out.print(zahl + " "); }
      • remove exceptions which aren't thrown (some methods claim to throw exceptions, which aren't actually thrown, they will be removed)
      • remove old commented unnecessary code
      • put {} around every if and else (this is to make the code more even, because some coders use it and some don't)

      there will be separate patches for each class of the package for easier reviewing and patching purposes

        Attachments

        1.
        [Refactoring] Package org.apache.ofbiz.base.util.collections Sub-task Closed Michael Brohl
        2.
        [Refactoring] Package org.apache.ofbiz.base.container Sub-task Closed Michael Brohl
        3.
        [Refactoring] Package org.apache.ofbiz.securityext.login Sub-task Closed Michael Brohl
        4.
        [Refactoring] Package org.apache.ofbiz.service Sub-task Closed Michael Brohl
        5.
        [Refactoring] Package org.apache.ofbiz.accounting.invoice Sub-task Closed Michael Brohl
        6.
        [Refactoring] Package org.apache.ofbiz.catalina.container Sub-task Closed Michael Brohl
        7.
        [Refactoring] Package org.apache.ofbiz.base.component Sub-task Closed Michael Brohl
        8.
        [Refactoring] Package org.apache.ofbiz.accounting.payment Sub-task Closed Michael Brohl
        9.
        [Refactoring] Package org.apache.ofbiz.common.authentication Sub-task Closed Michael Brohl
        10.
        [Refactoring] Package org.apache.ofbiz.common.email Sub-task Closed Michael Brohl
        11.
        [Refactoring] Package org.apache.ofbiz.accounting.tax Sub-task Closed Michael Brohl
        12.
        [Refactoring] Package org.apache.ofbiz.common.image Sub-task Closed Michael Brohl
        13.
        [Refactoring] Package org.apache.ofbiz.accounting.thirdparty.clearcommerce Sub-task Closed Michael Brohl
        14.
        [Refactoring] Package org.apache.ofbiz.common.login Sub-task Closed Michael Brohl
        15.
        [Refactoring] Package org.apache.ofbiz.accounting.thirdparty.eway Sub-task Closed Michael Brohl
        16.
        [Refactoring] Package org.apache.ofbiz.accounting.thirdparty.gosoftware Sub-task Closed Michael Brohl
        17.
        [Refactoring] Package org.apache.ofbiz.common.qrcode Sub-task Closed Michael Brohl
        18.
        [Refactoring] Package org.apache.ofbiz.accounting.finaccount Sub-task Closed Michael Brohl
        19.
        [Refactoring] Packages org.apache.ofbiz.accounting.period Sub-task Closed Michael Brohl
        20.
        [Refactoring] Package org.apache.ofbiz.common.preferences Sub-task Closed Michael Brohl
        21.
        [Refactoring] Package org.apache.ofbiz.base.concurrent Sub-task Closed Michael Brohl
        22.
        [Refactoring] Package org.apache.ofbiz.base.conversion Sub-task Closed Michael Brohl
        23.
        [Refactoring] Package org.apache.ofbiz.common Sub-task Closed Michael Brohl
        24.
        [Refactoring] Package org.apache.ofbiz.base.lang Sub-task Closed Michael Brohl
        25.
        [Refactoring] Package org.apache.ofbiz.service.group Sub-task Closed Michael Brohl
        26.
        [Refactoring] Package org.apache.ofbiz.widget.renderer.html Sub-task Closed Michael Brohl
        27.
        [Refactoring] Package org.apache.ofbiz.service.engine Sub-task Closed Michael Brohl
        28.
        [Refactoring] Package org.apache.ofbiz.base.config Sub-task Closed Michael Brohl
        29.
        [Refactoring] Package org.apache.ofbiz.base.metrics Sub-task Closed Michael Brohl
        30.
        [Refactoring] Package org.apache.ofbiz.base.start Sub-task Closed Michael Brohl
        31.
        [Refactoring] Package org.apache.ofbiz.base.test Sub-task Closed Michael Brohl
        32.
        [Refactoring] Package org.apache.ofbiz.base.util.cache Sub-task Closed Michael Brohl
        33.
        [Refactoring] Package org.apache.ofbiz.base.util.cache.test Sub-task Closed Michael Brohl
        34.
        [Refactoring] Package org.apache.ofbiz.base.util.template Sub-task Closed Michael Brohl
        35.
        [Refactoring] Package org.apache.ofbiz.base.crypto Sub-task Closed Michael Brohl
        36.
        [Refactoring] Package org.apache.ofbiz.service.mail Sub-task Closed Michael Brohl
        37.
        [Refactoring] Package org.apache.ofbiz.base.util Sub-task Closed Michael Brohl
        38.
        [Refactoring] Package org.apache.ofbiz.service.semaphore Sub-task Closed Michael Brohl
        39.
        [Refactoring] Package org.apache.ofbiz.service.calendar Sub-task Closed Michael Brohl
        40.
        [Refactoring] Package org.apache.ofbiz.service.test Sub-task Closed Michael Brohl
        41.
        [Refactoring] Package org.apache.ofbiz.widget.cache Sub-task Closed Michael Brohl
        42.
        [Refactoring] Package org.apache.ofbiz.entity.cache Sub-task Closed Michael Brohl
        43.
        [Refactoring] Package org.apache.ofbiz.widget.renderer Sub-task Closed Michael Brohl
        44.
        [Refactoring] Package org.apache.ofbiz.entity.serialize Sub-task Closed Michael Brohl
        45.
        [Refactoring] Package org.apache.ofbiz.entity.test Sub-task Closed Michael Brohl
        46.
        [Refactoring] Package org.apache.ofbiz.entity.finder Sub-task Closed Michael Brohl
        47.
        [Refactoring] Package org.apache.ofbiz.service.job Sub-task Closed Michael Brohl
        48.
        [Refactoring] Package org.apache.ofbiz.widget.model Sub-task Closed Michael Brohl
        49.
        [Refactoring] Package org.apache.ofbiz.entity.condition Sub-task Closed Michael Brohl
        50.
        [Refactoring] Package org.apache.ofbiz.entity Sub-task Closed Michael Brohl
        51.
        [Refactoring] Package org.apache.ofbiz.service.rmi.socket.ssl Sub-task Closed Michael Brohl
        52.
        [Refactoring] Package org.apache.ofbiz.widget.renderer.macro Sub-task Closed Michael Brohl
        53.
        [Refactoring] Package org.apache.ofbiz.workeffort.workeffort Sub-task Closed Michael Brohl
        54.
        [Refactoring] Package org.apache.ofbiz.entity.transaction Sub-task Closed Michael Brohl
        55.
        [Refactoring] Package org.apache.ofbiz.datafile Sub-task Closed Michael Brohl
        56.
        [Refactoring] Package org.apache.ofbiz.order.shoppinglist Sub-task Closed Michael Brohl
        57.
        [Refactoring] Package org.apache.ofbiz.order.shoppinglist Sub-task Closed Michael Brohl
        58.
        [Refactoring] Package org.apache.ofbiz.order.test Sub-task Closed Michael Brohl
        59.
        [Refactoring] Package org.apache.ofbiz.order.thirdparty.paypal Sub-task Closed Michael Brohl
        60.
        [Refactoring] Package org.apache.ofbiz.order.shoppingcart.product Sub-task Closed Michael Brohl
        61.
        [Refactoring] Package org.apache.ofbiz.party.communication Sub-task Closed Michael Brohl
        62.
        [Refactoring] Package org.apache.ofbiz.party.contact Sub-task Closed Michael Brohl
        63.
        [Refactoring] Package org.apache.ofbiz.party.party Sub-task Closed Michael Brohl
        64.
        [Refactoring] Package org.apache.ofbiz.product.config Sub-task Closed Michael Brohl
        65.
        [Refactoring] Package org.apache.ofbiz.product.image Sub-task Closed Michael Brohl
        66.
        [Refactoring] Package org.apache.ofbiz.product.imagemanagement Sub-task Closed Michael Brohl
        67.
        [Refactoring] Package org.apache.ofbiz.product.inventory Sub-task Closed Michael Brohl
        68.
        [Refactoring] Package org.apache.ofbiz.product.product Sub-task Closed Michael Brohl
        69.
        [Refactoring] Package org.apache.ofbiz.product.subscription Sub-task Closed Michael Brohl
        70.
        [Refactoring] Package org.apache.ofbiz.product.supplier Sub-task Closed Michael Brohl
        71.
        [Refactoring] Package org.apache.ofbiz.product.test Sub-task Closed Michael Brohl
        72.
        [Refactoring] Package org.apache.ofbiz.content.data Sub-task Closed Michael Brohl
        73.
        [Refactoring] Package org.apache.ofbiz.content.output Sub-task Closed Michael Brohl
        74.
        [Refactoring] Package org.apache.ofbiz.content.survey Sub-task Closed Michael Brohl
        75.
        [Refactoring] Package org.apache.ofbiz.content.webapp.ftl Sub-task Closed Michael Brohl
        76.
        [Refactoring] Package org.apache.ofbiz.product.promo Sub-task Closed Michael Brohl
        77.
        [Refactoring] Package org.apache.ofbiz.product.spreadsheetimport Sub-task Closed Michael Brohl
        78.
        [Refactoring] Package org.apache.ofbiz.order.shoppingcart Sub-task Closed Michael Brohl
        79.
        [Refactoring] Package org.apache.ofbiz.order.order Sub-task Closed Michael Brohl
        80.
        [Refactoring] Package org.apache.ofbiz.product.category Sub-task Patch Available Unassigned
        81.
        [Refactoring] Package org.apache.ofbiz.product.category.ftl Sub-task Closed Michael Brohl

          Activity

            People

            • Assignee:
              mbrohl Michael Brohl
              Reporter:
              Dennis Balkir Dennis Balkir
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: