[OFBIZ-9735] [FB] Package org.apache.ofbiz.party.contact

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Implemented
• Affects Version/s: Trunk
• Fix Version/s: 17.12.01
• Component/s: party
• Assignee: Michael Brohl
• Reporter: Julian Leichert
• Created: 21/Sep/17 12:39
• Updated: 08/Dec/17 22:20
• Resolved: 08/Dec/17 22:20

Description

ContactMechServices.java:508, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

• RCN: Redundant nullcheck of relatedEntityToSet, which is known to be non-null in org.apache.ofbiz.party.contact.ContactMechServices.updatePostalAddress(DispatchContext, Map)

This method contains a redundant check of a known non-null value against the constant null.

ContactMechServices.java:710, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

• RCN: Redundant nullcheck of relatedEntityToSet, which is known to be non-null in org.apache.ofbiz.party.contact.ContactMechServices.updateTelecomNumber(DispatchContext, Map)

This method contains a redundant check of a known non-null value against the constant null.

ContactMechServices.java:1064, DM_DEFAULT_ENCODING

• Dm: Found reliance on default encoding in org.apache.ofbiz.party.contact.ContactMechServices.createEmailAddressVerification(DispatchContext, Map): String.getBytes()

Found a call to a method which will perform a byte to String (or String to byte) conversion, and will assume that the default platform encoding is suitable. This will cause the application behaviour to vary between platforms. Use an alternative API and specify a charset name or Charset object explicitly.

ContactMechWorker.java:825, DM_CONVERT_CASE

• Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.party.contact.ContactMechWorker.isUspsAddress(GenericValue)

A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the

String.toUpperCase( Locale l )
String.toLowerCase( Locale l )

versions instead.

ContactMechWorker.java:854, DM_CONVERT_CASE

• Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.party.contact.ContactMechWorker.isCompanyAddress(GenericValue, String)

A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the

String.toUpperCase( Locale l )
String.toLowerCase( Locale l )

versions instead.

ContactMechWorker.java:889, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

• RCN: Redundant nullcheck of postalAddresses, which is known to be non-null in org.apache.ofbiz.party.contact.ContactMechWorker.isCompanyAddress(GenericValue, String)

This method contains a redundant check of a known non-null value against the constant null.