[OFBIZ-9711] [FB] Package org.apache.ofbiz.entity.cache

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Implemented
• Affects Version/s: Trunk
• Fix Version/s: 17.12.01
• Component/s: framework
• Assignee: Michael Brohl
• Reporter: Dennis Balkir
• Created: 13/Sep/17 10:10
• Updated: 28/Oct/17 13:37
• Resolved: 28/Oct/17 13:37

Description

• AbstractEntityConditionCache.java:68, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
  RCN: Redundant nullcheck of model, which is known to be non-null in org.apache.ofbiz.entity.cache.AbstractEntityConditionCache.remove(GenericEntity)

This method contains a redundant check of a known non-null value against the constant null.

• AbstractEntityConditionCache.java:169, UCF_USELESS_CONTROL_FLOW
  UCF: Useless control flow in org.apache.ofbiz.entity.cache.AbstractEntityConditionCache.storeHook(boolean, GenericEntity, GenericEntity)

This method contains a useless control flow statement, where control flow continues onto the same place regardless of whether or not the branch is taken. For example, this is caused by having an empty statement block for an if statement:

if (argv.length == 0)

{ // TODO: handle this case }

• AbstractEntityConditionCache.java:183, UCF_USELESS_CONTROL_FLOW
  UCF: Useless control flow in org.apache.ofbiz.entity.cache.AbstractEntityConditionCache.storeHook(String, boolean, List, List)

This method contains a useless control flow statement, where control flow continues onto the same place regardless of whether or not the branch is taken. For example, this is caused by having an empty statement block for an if statement:

if (argv.length == 0)

{ // TODO: handle this case }