[OFBIZ-9705] [FB] Package org.apache.ofbiz.entity.serialize

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Implemented
• Affects Version/s: Trunk
• Fix Version/s: 17.12.01
• Component/s: ALL APPLICATIONS, ALL COMPONENTS
• Assignee: Michael Brohl
• Reporter: Julian Leichert
• Created: 11/Sep/17 14:01
• Updated: 22/Oct/17 13:04
• Resolved: 22/Oct/17 13:04

Description

XmlSerializer.java:134, NP_LOAD_OF_KNOWN_NULL_VALUE

• NP: Load of known null value in org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSingle(Object, Document)

The variable referenced at this point is known to be null due to an earlier check against null. Although this is valid, it might be a mistake (perhaps you intended to refer to a different variable, or perhaps the earlier check to see if the variable is null should have been a check to see if it was non-null).

XmlSerializer.java:494, LI_LAZY_INIT_STATIC

• LI: Incorrect lazy initialization of static field org.apache.ofbiz.entity.serialize.XmlSerializer.simpleDateFormatter in org.apache.ofbiz.entity.serialize.XmlSerializer.getDateFormat()

This method contains an unsynchronized lazy initialization of a non-volatile static field. Because the compiler or processor may reorder instructions, threads are not guaranteed to see a completely initialized object, if the method can be called by multiple threads. You can make the field volatile to correct the problem. For more information, see the Java Memory Model web site.