Details

      Description

      XmlSerializer.java:134, NP_LOAD_OF_KNOWN_NULL_VALUE

      • NP: Load of known null value in org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSingle(Object, Document)

      The variable referenced at this point is known to be null due to an earlier check against null. Although this is valid, it might be a mistake (perhaps you intended to refer to a different variable, or perhaps the earlier check to see if the variable is null should have been a check to see if it was non-null).

      XmlSerializer.java:494, LI_LAZY_INIT_STATIC

      • LI: Incorrect lazy initialization of static field org.apache.ofbiz.entity.serialize.XmlSerializer.simpleDateFormatter in org.apache.ofbiz.entity.serialize.XmlSerializer.getDateFormat()

      This method contains an unsynchronized lazy initialization of a non-volatile static field. Because the compiler or processor may reorder instructions, threads are not guaranteed to see a completely initialized object, if the method can be called by multiple threads. You can make the field volatile to correct the problem. For more information, see the Java Memory Model web site.

        Activity

        Hide
        jleichert Julian Leichert added a comment -

        Line 134: null instead of known null object, for better visibility
        Line 494: added volatile keyword

        Show
        jleichert Julian Leichert added a comment - Line 134: null instead of known null object, for better visibility Line 494: added volatile keyword
        Hide
        mbrohl Michael Brohl added a comment -

        Thanks Julian,

        your patch is in trunk r1812910.

        Show
        mbrohl Michael Brohl added a comment - Thanks Julian, your patch is in trunk r1812910.

          People

          • Assignee:
            mbrohl Michael Brohl
            Reporter:
            jleichert Julian Leichert
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development