Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: framework
    • Labels:
      None

      Description

      • WidgetContextCacheKey.java:140, WMI_WRONG_MAP_ITERATOR
        WMI: org.apache.ofbiz.widget.cache.WidgetContextCacheKey.toString() makes inefficient use of keySet iterator instead of entrySet iterator

      This method accesses the value of a Map entry, using a key that was retrieved from a keySet iterator. It is more efficient to use an iterator on the entrySet of the map, to avoid the Map.get(key) lookup.

        Activity

        Hide
        Dennis Balkir Dennis Balkir added a comment -
        • Diamond Operators fixed

        class WidgetContextCacheKey:

        • Line 137 and following: optimized the performance with the use of entrySet
        Show
        Dennis Balkir Dennis Balkir added a comment - Diamond Operators fixed class WidgetContextCacheKey: Line 137 and following: optimized the performance with the use of entrySet
        Hide
        mbrohl Michael Brohl added a comment -

        Thanks Dennis,

        your patch is in trunk r1812164.

        Show
        mbrohl Michael Brohl added a comment - Thanks Dennis, your patch is in trunk r1812164.

          People

          • Assignee:
            mbrohl Michael Brohl
            Reporter:
            Dennis Balkir Dennis Balkir
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development