Attach filesAttach ScreenshotVotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      GroupModel.java:55, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

      • RCN: Redundant nullcheck of org.apache.ofbiz.service.group.GroupModel.groupName, which is known to be non-null in new org.apache.ofbiz.service.group.GroupModel(Element)

      This method contains a redundant check of a known non-null value against the constant null.

      GroupServiceModel.java:107, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

      • RCN: Redundant nullcheck of model, which is known to be non-null in org.apache.ofbiz.service.group.GroupServiceModel.invoke(ServiceDispatcher, String, Map)

      This method contains a redundant check of a known non-null value against the constant null.

      ServiceGroupReader.java:43, MS_SHOULD_BE_FINAL, Priorit├Ąt: Hoch

      • MS: org.apache.ofbiz.service.group.ServiceGroupReader.groupsCache isn't final but should be

      This static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability.

      ServiceGroupReader.java:78, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

      • RCN: Redundant nullcheck of groupName, which is known to be non-null in org.apache.ofbiz.service.group.ServiceGroupReader.addGroupDefinitions(ResourceHandler)

      This method contains a redundant check of a known non-null value against the constant null.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mbrohl Michael Brohl
            jleichert Julian Leichert
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment