Details

    • Type: Improvement
    • Status: Patch Available
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: ALL COMPONENTS
    • Labels:
      None

      Description

      replaced private to protected so that CommonEvents.java is more usable to derived classes.

      1. OFBIZ-9673.patch
        2 kB
        Wai
      2. OFBIZ-9673.patch
        0.8 kB
        Wai

        Activity

        Show
        jacques.le.roux Jacques Le Roux added a comment - Hi Wai, Here you go https://lists.apache.org/thread.html/c24787c2143b47be925dfc7caf2bdf3c931f7779d6524dde349ca6a0@%3Cdev.ofbiz.apache.org%3E
        Hide
        wt Wai added a comment -

        Can you give me a link to the dev ML that discusses this request?

        Show
        wt Wai added a comment - Can you give me a link to the dev ML that discusses this request?
        Hide
        wt Wai added a comment -

        I'm deriving from CommonEvents.java and creating a new method that calls CommonEvent.writeJSONtoResponse(). Unfortunately, CommonEvent.writeJSONtoResponse() is private. Hence, I could not compile. I believe that methods that should not be accessible from other classes should at least allow derived classes to extend it. Hence, changing it to "protected" rather than "private" is more appropriate.

        Show
        wt Wai added a comment - I'm deriving from CommonEvents.java and creating a new method that calls CommonEvent.writeJSONtoResponse(). Unfortunately, CommonEvent.writeJSONtoResponse() is private. Hence, I could not compile. I believe that methods that should not be accessible from other classes should at least allow derived classes to extend it. Hence, changing it to "protected" rather than "private" is more appropriate.
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        Hi Wai,

        On request on dev ML I reverted at r1807142

        Maybe you can give more justifications for your request, else please as invalid.

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited Hi Wai, On request on dev ML I reverted at r1807142 Maybe you can give more justifications for your request, else please as invalid.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Wai

        Your patch is in trunk at revision: 1807045

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Wai Your patch is in trunk at revision: 1807045
        Hide
        wt Wai added a comment -

        Yes, no modifier would be just fine.

        Show
        wt Wai added a comment - Yes, no modifier would be just fine.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Hi Wai,

        I see no problems with that. I'll though wait a bit other opinions. Would not "no modifier" be enough. I mean do you need to access from classes external to the package?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Hi Wai, I see no problems with that. I'll though wait a bit other opinions. Would not "no modifier" be enough. I mean do you need to access from classes external to the package?

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            wt Wai
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development