Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9644

Fix references where Mime type is displayed in HTML encoded pattern

    Details

      Description

      I found various instances where the mimeTypeId is displayed in HTML encoded pattern over UI.
      As per discussion on the ticket OFBIZ-9621, Jacques suggested fixing this scenario across the application.

      1. OFBIZ-9644-plugins-trunk.patch
        2 kB
        Ankit Joshi
      2. OFBIZ-9644-trunk.patch
        18 kB
        Ankit Joshi

        Activity

        Hide
        ankit.joshi Ankit Joshi added a comment -

        Fixed MimeType field references displayed in HTML encoded pattern.

        Show
        ankit.joshi Ankit Joshi added a comment - Fixed MimeType field references displayed in HTML encoded pattern.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Ankit, this was annoying me for years

        Your patch looks good to me, just a question why encode-output="true" in AddLayout form?

        <field name="drMimeTypeId" encode-output="true">

        Also we should remove a duplicated _<field name="drMimeTypeId" _ block there, I suggest the 2nd

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Ankit, this was annoying me for years Your patch looks good to me, just a question why encode-output="true" in AddLayout form? <field name="drMimeTypeId" encode-output="true"> Also we should remove a duplicated _<field name="drMimeTypeId" _ block there, I suggest the 2nd
        Hide
        ankit.joshi Ankit Joshi added a comment -

        Thanks Jacques Le Roux for the review. It was a typo.
        I have also found duplicate reference of dataResourceTypeId field along with drMimeTypeId in AddLayout form.
        Fixed both duplicate references and corrected encode-output flag.

        Show
        ankit.joshi Ankit Joshi added a comment - Thanks Jacques Le Roux for the review. It was a typo. I have also found duplicate reference of dataResourceTypeId field along with drMimeTypeId in AddLayout form. Fixed both duplicate references and corrected encode-output flag.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Ankit,

        Your patch is in
        trunk r1806951
        R16.11 r1806953
        R15.12 r1806954
        R14.12 r1806956

        Actually as a best practise it's better to not remove older patches. SImply add the new patch with the same name and Jira will take care of graying the old one. This is explained here: https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices look for "gray"

        "Why?" You might ask. Here for instance I could compare the patches (easier review) and I'd not have to revert the patch I already applied but just had to change manually (easier handling). Fortunately you comment is clear so not a big deal here, just to let you know

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Ankit, Your patch is in trunk r1806951 R16.11 r1806953 R15.12 r1806954 R14.12 r1806956 Actually as a best practise it's better to not remove older patches. SImply add the new patch with the same name and Jira will take care of graying the old one. This is explained here: https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices look for "gray" "Why?" You might ask. Here for instance I could compare the patches (easier review) and I'd not have to revert the patch I already applied but just had to change manually (easier handling). Fortunately you comment is clear so not a big deal here, just to let you know
        Hide
        ankit.joshi Ankit Joshi added a comment -

        Thanks Jacques Le Roux. I'll take care of it in future.

        Show
        ankit.joshi Ankit Joshi added a comment - Thanks Jacques Le Roux . I'll take care of it in future.

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            ankit.joshi Ankit Joshi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development