Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: framework
    • Labels:
      None

      Description

      • ImageTransform.java:119, DM_STRING_TOSTRING
        Dm: org.apache.ofbiz.common.image.ImageTransform.scaleImage(BufferedImage, double, double, Map, String, Locale) invokes toString() method on a String

      Calling String.toString() is just a redundant operation. Just use the String.

        Activity

        Hide
        Dennis Balkir Dennis Balkir added a comment -
        • Diamond Operators fixed
        • Line 119: removed toString because get(„height“) returns a string
        • Line 124: removed the toString because get(„width“) returns a string
        Show
        Dennis Balkir Dennis Balkir added a comment - Diamond Operators fixed Line 119: removed toString because get(„height“) returns a string Line 124: removed the toString because get(„width“) returns a string
        Hide
        mbrohl Michael Brohl added a comment -

        Thanks Dennis,

        your patch is in trunk r1811423.

        Show
        mbrohl Michael Brohl added a comment - Thanks Dennis, your patch is in trunk r1811423.

          People

          • Assignee:
            mbrohl Michael Brohl
            Reporter:
            Dennis Balkir Dennis Balkir
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development