Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9607

Use from-field pattern instead of value=${***} pattern in 'set' element

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: Upcoming Release
    • Component/s: None
    • Labels:
      None

      Description

      Currently, there are many occurrences in the code base where we use value=${***} pattern to assign the value to some variable.
      Instead of this, we should use from-field for better performance.

      1. OFBIZ-9607_Order.patch
        14 kB
        Rohit Rai
      2. OFBIZ-9607_Party.patch
        21 kB
        Rohit Rai
      3. OFBIZ-9607_Product.patch
        18 kB
        Rohit Rai
      4. OFBIZ-9607_Accounting.patch
        31 kB
        Rohit Rai
      5. OFBIZ-9607_Content.patch
        6 kB
        Rohit Rai
      6. OFBIZ-9607_Manufacturing.patch
        3 kB
        Rohit Rai
      7. OFBIZ-9607_Marketing.patch
        11 kB
        Rohit Rai
      8. OFBIZ-9607_HR.patch
        10 kB
        Rohit Rai
      9. OFBIZ-9607_Workeffort.patch
        4 kB
        Rohit Rai
      10. OFBIZ-9607_Framework.patch
        9 kB
        Rohit Rai
      11. OFBIZ-9607_AssetMaint.patch
        4 kB
        Rohit Rai
      12. OFBIZ-9607_BI.patch
        0.9 kB
        Rohit Rai
      13. OFBIZ-9607_BIRT.patch
        0.9 kB
        Rohit Rai
      14. OFBIZ-9607_Ebay_Store.patch
        7 kB
        Rohit Rai
      15. OFBIZ-9607_Ecommerce.patch
        6 kB
        Rohit Rai
      16. OFBIZ-9607_Example.patch
        2 kB
        Rohit Rai
      17. OFBIZ-9607_HHFacility.patch
        2 kB
        Rohit Rai
      18. OFBIZ-9607_MyPortal.patch
        0.9 kB
        Rohit Rai
      19. OFBIZ-9607_PriCat.patch
        2 kB
        Rohit Rai
      20. OFBIZ-9607_ProjectMgr.patch
        4 kB
        Rohit Rai
      21. OFBIZ-9607_Scrum.patch
        11 kB
        Rohit Rai
      22. OFBIZ-9607_Solr.patch
        0.8 kB
        Rohit Rai
      23. OFBIZ-9607_WebPos.patch
        1 kB
        Rohit Rai
      24. OFBIZ-9607-CommonExt.patch
        2 kB
        Rohit Rai
      25. OFBIZ-9607_Themes.patch
        2 kB
        Rohit Rai
      26. OFBIZ-9607_Typo_Content.patch
        0.9 kB
        Rohit Rai

        Issue Links

          Activity

          Hide
          deepak.dixit Deepak Dixit added a comment -

          Thanks Rohit,
          This has been committed at ofbiz-framework at r#1806714

          Show
          deepak.dixit Deepak Dixit added a comment - Thanks Rohit, This has been committed at ofbiz-framework at r#1806714
          Hide
          rohit.rai Rohit Rai added a comment -

          Hi Deepak,
          While testing this I stumbled upon a typo in the previous patch. I am uploading the correct patch. Sorry for the inconvenience.

          Show
          rohit.rai Rohit Rai added a comment - Hi Deepak, While testing this I stumbled upon a typo in the previous patch. I am uploading the correct patch. Sorry for the inconvenience.
          Hide
          deepak.dixit Deepak Dixit added a comment -

          This has been committed at ofbiz-framework trunk at r#1806326 and ofbiz-plugins at r#1806327
          Thanks Suraj Khurana and Rohit Rai for your contribution.

          Show
          deepak.dixit Deepak Dixit added a comment - This has been committed at ofbiz-framework trunk at r#1806326 and ofbiz-plugins at r#1806327 Thanks Suraj Khurana and Rohit Rai for your contribution.
          Hide
          rohit.rai Rohit Rai added a comment -

          Made a separate patch for each component, all the framework changes are in a separate patch and made a separate patch for each plugin. Please review the patch. Thanks!

          Show
          rohit.rai Rohit Rai added a comment - Made a separate patch for each component, all the framework changes are in a separate patch and made a separate patch for each plugin. Please review the patch. Thanks!
          Hide
          rohit.rai Rohit Rai added a comment -

          The occurrences are scattered around various components. I will change the occurrences, and will provide patches component wise.

          Attaching the patch for the Order component.

          Show
          rohit.rai Rohit Rai added a comment - The occurrences are scattered around various components. I will change the occurrences, and will provide patches component wise. Attaching the patch for the Order component.
          Hide
          suraj.khurana Suraj Khurana added a comment -

          Hi Jacques,

          Thanks for your inputs, sounds good to me as well.
          We should refactor only <actions> as of now and shall not change any simple methods.

          Show
          suraj.khurana Suraj Khurana added a comment - Hi Jacques, Thanks for your inputs, sounds good to me as well. We should refactor only <actions> as of now and shall not change any simple methods.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Hi Suraj,

          Since we have decided to deprecate Minilang at least we should not worry about Minilang code, <actions> is another part (for now we might decide to use only Groovy there also). So I wonder if globally it's worth it...

          Show
          jacques.le.roux Jacques Le Roux added a comment - Hi Suraj, Since we have decided to deprecate Minilang at least we should not worry about Minilang code, <actions> is another part (for now we might decide to use only Groovy there also). So I wonder if globally it's worth it...

            People

            • Assignee:
              rohit.rai Rohit Rai
              Reporter:
              suraj.khurana Suraj Khurana
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development