Details

      Description

      Hi

      In a recent github mirror, I've found suspicious code.
      Branch: master
      path: framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java

      ...
      1588         protected final List<String> messages = new LinkedList<String>();
      ...
      1596         protected int updateData(Collection<String> messages) {
      1597             if (messages != null && UtilValidate.isNotEmpty(this.messages)) {
      1598                 messages.addAll(messages);
      1599             }
      1600             return count;
      1601         }
      1602     }
      

      In Line 1598, `messages.addAll' should be `this.messages.addAll'? This might not be an issue but I wanted to report this just in case.

      Thanks!

        Attachments

          Activity

            People

            • Assignee:
              jacques.le.roux Jacques Le Roux
              Reporter:
              lifove JC
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: