Details

      Description

      Hi

      In a recent github mirror, I've found suspicious code.
      Branch: master
      path: framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java

      ...
      1588         protected final List<String> messages = new LinkedList<String>();
      ...
      1596         protected int updateData(Collection<String> messages) {
      1597             if (messages != null && UtilValidate.isNotEmpty(this.messages)) {
      1598                 messages.addAll(messages);
      1599             }
      1600             return count;
      1601         }
      1602     }
      

      In Line 1598, `messages.addAll' should be `this.messages.addAll'? This might not be an issue but I wanted to report this just in case.

      Thanks!

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks JC for the report.

        Indeed, that's a bug.

        Fortunately it's only a counter used to log messages. So we only missed the following messages:

        Reviewed x primary key fields from database. (When OFBiz starts and when using the webtools checkDb feature)
        ==== TOTAL Foreign Key Indices Created: (When using the webtools checkDb feature and creating FKs)
        ==== TOTAL Declared Indices Created: (When using the webtools checkDb feature and creating indices)

        They were no impacts on the DB.

        I fixed the bug in
        trunk r1805143
        R16.11 r1805144
        R15.12 & R14.12 r1805145

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks JC for the report. Indeed, that's a bug. Fortunately it's only a counter used to log messages. So we only missed the following messages: Reviewed x primary key fields from database. (When OFBiz starts and when using the webtools checkDb feature) ==== TOTAL Foreign Key Indices Created: (When using the webtools checkDb feature and creating FKs) ==== TOTAL Declared Indices Created: (When using the webtools checkDb feature and creating indices) They were no impacts on the DB. I fixed the bug in trunk r1805143 R16.11 r1805144 R15.12 & R14.12 r1805145

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            lifove JC
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development