[OFBIZ-9572] Replace all "BigDecimal ZERO" by BigDecimal.ZERO

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Implemented
• Fix Version/s: 18.12.01
• Assignee: Jacques Le Roux
• Reporter: Jacques Le Roux
• Created: 14/Aug/17 09:09
• Updated: 02/Aug/19 16:18
• Resolved: 13/Feb/18 12:49

Description

Using "BigDecimal ZERO" instead of BigDecimal.ZERO does not add anything but more useless code. They are both constants and the compiler will made them so.

1. But, like in any BigDecimal comparison, values compared to BigDecimal.ZERO must be weighted by using setScale()
2. Like I did in OFBIZ-9571 we must always use the setScale() variant with integer but the one with RoundingMode.

Issue Links

• is related to: OFBIZ-9571 [DEPRECATION] Replace BigDecimal.ROUND_* by RoundingMode.*