[OFBIZ-9567] [FB] Package org.apache.ofbiz.base.metrics

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: Release Branch 13.07, Release Branch 14.12, Release Branch 15.12, 16.11.04
• Component/s: base
• Assignee: Jacques Le Roux
• Reporter: Dennis Balkir
• Created: 10/Aug/17 07:53
• Updated: 10/Aug/17 10:34
• Resolved: 10/Aug/17 10:34

Description

• MetricsFactory.java:236, ICAST_IDIV_CAST_TO_DOUBLE
  ICAST: Integral division result cast to double or float in org.apache.ofbiz.base.metrics.MetricsFactory$MetricsImpl.recordServiceRate(int, long)

This code casts the result of an integral division (e.g., int or long division) operation to double or float. Doing division on integers truncates the result to the integer value closest to zero. The fact that the result was cast to double suggests that this precision should have been retained. What was probably meant was to cast one or both of the operands to double before performing the division. Here is an example:

int x = 2;
int y = 5;
// Wrong: yields result 0.0
double value1 = x / y;

// Right: yields result 0.4
double value2 = x / (double) y;