Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9550

Manage life span of marketing related entites

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Upcoming Release
    • Component/s: marketing
    • Labels:
      None

      Description

      Found few entities related to marketing component that should maintain life span of data. Here is the list:

      1) MarketingCampaignPrice
      2) MarketingCampaignPromo
      3) MarketingCampaignRole

      Will add more if found.

      1. OFBIZ-9550.patch
        7 kB
        Suraj Khurana

        Issue Links

          Activity

          Hide
          suraj.khurana Suraj Khurana added a comment -

          Here is the patch with the proper fix.

          Also added crud service for these entities as well.

          Show
          suraj.khurana Suraj Khurana added a comment - Here is the patch with the proper fix. Also added crud service for these entities as well.
          Hide
          soledad Nicolas Malin added a comment -

          Hello Suraj,
          Thanks for your submission.
          I have a doubt about remove directly some service definition with deprecated procedure. I will open a thread on mailing list to have some suggest how to manage it.

          Show
          soledad Nicolas Malin added a comment - Hello Suraj, Thanks for your submission. I have a doubt about remove directly some service definition with deprecated procedure. I will open a thread on mailing list to have some suggest how to manage it.
          Hide
          soledad Nicolas Malin added a comment -

          Hello Suraj, I commited your patch on trunk at revision 1805961 with set as deprecated all service that you removed.

          Thanks

          Show
          soledad Nicolas Malin added a comment - Hello Suraj, I commited your patch on trunk at revision 1805961 with set as deprecated all service that you removed. Thanks
          Hide
          suraj.khurana Suraj Khurana added a comment -

          Thanks Nicolas Malin.

          Show
          suraj.khurana Suraj Khurana added a comment - Thanks Nicolas Malin .
          Hide
          deepak.dixit Deepak Dixit added a comment -

          Hi Suraj Khurana/Nicolas Malin,

          I think we need to update Data Migration document with alter query.

          As we changed the PK and need to set the default values for old records.

          Show
          deepak.dixit Deepak Dixit added a comment - Hi Suraj Khurana / Nicolas Malin , I think we need to update Data Migration document with alter query. As we changed the PK and need to set the default values for old records.
          Hide
          soledad Nicolas Malin added a comment -

          Yes sure Deepak, it's done. Thanks for the remind

          Show
          soledad Nicolas Malin added a comment - Yes sure Deepak, it's done. Thanks for the remind
          Hide
          deepak.dixit Deepak Dixit added a comment -
          Show
          deepak.dixit Deepak Dixit added a comment - Thanks Nicolas Malin

            People

            • Assignee:
              suraj.khurana Suraj Khurana
              Reporter:
              suraj.khurana Suraj Khurana
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development