Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9530

Missing action in empty if-statement in accounting.PaymentGatewayServices

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • Trunk
    • 16.11.04
    • accounting
    • None
    • Patch

    Description

      In the method processAuthResult line 1889 there is an empty if-statement for the case that authResult is null. It seems like somebody was planning to cover the case but forgot to add code.
      I would suggest to return a service error when the authResult is null since otherwise it cannot be determined if the payment is authorized or not.

      boolean authResultOk = authResult.booleanValue();
                  
                  if (authResultOk) {
                      orderPaymentPreference.set("statusId", "PAYMENT_AUTHORIZED");
                  } else {
                      orderPaymentPreference.set("statusId", "PAYMENT_DECLINED");
                  }
      

      Attachments

        1. OFBIZ-9530_PaymentGatewayServices_bugfix.patch
          0.8 kB
          Kyra Pritzel-Hentley
        2. OFBIZ-9530_PaymentGatewayServices_bugfix.patch
          2 kB
          Kyra Pritzel-Hentley

        Activity

          People

            jleroux Jacques Le Roux
            Kyra Pritzel-Hentley Kyra Pritzel-Hentley
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: