[OFBIZ-9530] Missing action in empty if-statement in accounting.PaymentGatewayServices

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: 16.11.04
• Component/s: accounting
• Flags: Patch
• Assignee: Jacques Le Roux
• Reporter: Kyra Pritzel-Hentley
• Created: 24/Jul/17 11:02
• Updated: 11/Aug/17 19:35
• Resolved: 11/Aug/17 19:35

Description

In the method processAuthResult line 1889 there is an empty if-statement for the case that authResult is null. It seems like somebody was planning to cover the case but forgot to add code.
I would suggest to return a service error when the authResult is null since otherwise it cannot be determined if the payment is authorized or not.

boolean authResultOk = authResult.booleanValue();
            
            if (authResultOk) {
                orderPaymentPreference.set("statusId", "PAYMENT_AUTHORIZED");
            } else {
                orderPaymentPreference.set("statusId", "PAYMENT_DECLINED");
            }