[OFBIZ-9527] [FB] Packages org.apache.ofbiz.accounting.period and org.apache.ofbiz.accounting.tax

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: 17.12.01
• Component/s: accounting
• Flags: Patch
• Assignee: Michael Brohl
• Reporter: Kyra Pritzel-Hentley
• Created: 24/Jul/17 08:47
• Updated: 18/Aug/17 20:19
• Resolved: 18/Aug/17 20:19

Description

PeriodServices.java:42, MS_SHOULD_BE_FINAL

• MS: org.apache.ofbiz.accounting.period.PeriodServices.module isn't final but should be
  This static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability.

After adjusting the FindBugs configuration, a new bug has been found in TaxAuthorityServices:

TaxAuthorityServices.java:350, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

• RCN: Redundant nullcheck of productCategoryCond, which is known to be non-null in org.apache.ofbiz.accounting.tax.TaxAuthorityServices.getTaxAdjustments(Delegator, GenericValue, GenericValue, String, String, Set, BigDecimal, BigDecimal, BigDecimal, BigDecimal, BigDecimal)
  This method contains a redundant check of a known non-null value against the constant null.