Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9434

Remove hard-coded instances of "IN" with ModelService.IN_PARAM

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: ALL COMPONENTS
    • Labels:
      None

      Description

      I found many occurrences in OFBiz where "IN" is used directly instead of ModelService.IN_PARAM which is the intended meaning/usage.

      Map<String, Object> addOrderItemShipGroupMap = dctx.makeValidContext("addOrderItemShipGroup", "IN", context);
      

        Activity

        Hide
        rishisolankii Rishi Solanki added a comment -

        +1

        Show
        rishisolankii Rishi Solanki added a comment - +1
        Hide
        mbrohl Michael Brohl added a comment -

        +1, can you provide a patch for it?

        Show
        mbrohl Michael Brohl added a comment - +1, can you provide a patch for it?
        Hide
        pawan.verma Pawan Verma added a comment -

        Attaching patch for this Task.

        Show
        pawan.verma Pawan Verma added a comment - Attaching patch for this Task.
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Thanks Devanshu and Pawan for your contribution.
        This has been done at
        ofbiz framework trunk at r#1801266

        Show
        deepak.dixit Deepak Dixit added a comment - Thanks Devanshu and Pawan for your contribution. This has been done at ofbiz framework trunk at r#1801266
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Replace some more hardcoded values for IN, OUT and IN_OUT param mode at ofbiz framework trunk at r#1801267

        Show
        deepak.dixit Deepak Dixit added a comment - Replace some more hardcoded values for IN, OUT and IN_OUT param mode at ofbiz framework trunk at r#1801267

          People

          • Assignee:
            deepak.dixit Deepak Dixit
            Reporter:
            devanshu.vyas Devanshu Vyas
          • Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development